Skip to content

Commit de363d5

Browse files
committed
Revert back to LlvmArchiveBuilder on all platforms
ArArchiveBuilder doesn't support reading thin archives, causing a regression.
1 parent 2cf101c commit de363d5

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

compiler/rustc_codegen_llvm/src/back/archive.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,9 @@ pub struct LlvmArchiveBuilderBuilder;
108108

109109
impl ArchiveBuilderBuilder for LlvmArchiveBuilderBuilder {
110110
fn new_archive_builder<'a>(&self, sess: &'a Session) -> Box<dyn ArchiveBuilder<'a> + 'a> {
111-
if sess.target.arch == "wasm32" || sess.target.arch == "wasm64" {
111+
// FIXME use ArArchiveBuilder on most targets again once reading thin archives is
112+
// implemented
113+
if true || sess.target.arch == "wasm32" || sess.target.arch == "wasm64" {
112114
Box::new(LlvmArchiveBuilder { sess, additions: Vec::new() })
113115
} else {
114116
Box::new(ArArchiveBuilder::new(sess, get_llvm_object_symbols))

0 commit comments

Comments
 (0)