Emscripten: Drop -lc the emcc driver will add it when it is needed

hoodmane · hoodmane · commit d565b20ab93c · 2022-06-20T10:44:58.000-07:00
According to sbc100, when linking with emcc we shouldn't pass -lc: > your best bet is to remove any/all explicit additions of -lc, since > the compiler driver (emcc) will add it if/when its needed. > (I don't think this is an emscripten bug BTW, but a rustc driver bug) emscripten-core/emscripten#17191 (comment)
diff --git a/compiler/rustc_codegen_ssa/src/back/linker.rs b/compiler/rustc_codegen_ssa/src/back/linker.rs
@@ -1048,6 +1048,10 @@ impl<'a> Linker for EmLinker<'a> {
     }
 
     fn link_staticlib(&mut self, lib: Symbol, _verbatim: bool) {
+        //  remove -lc: the compiler driver emcc will add it if its needed.
+        if lib.as_str() == "c" {
+            return;
+        }
         self.cmd.arg("-l").sym_arg(lib);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1048,6 +1048,10 @@ impl<'a> Linker for EmLinker<'a> {`
`1048`	`1048`	`}`
`1049`	`1049`
`1050`	`1050`	`fn link_staticlib(&mut self, lib: Symbol, _verbatim: bool) {`
	`1051`	`+ // remove -lc: the compiler driver emcc will add it if its needed.`
	`1052`	`+ if lib.as_str() == "c" {`
	`1053`	`+ return;`
	`1054`	`+ }`
`1051`	`1055`	`self.cmd.arg("-l").sym_arg(lib);`
`1052`	`1056`	`}`
`1053`	`1057`