hir: Simplify hir_owner_nodes query

petrochenkov · petrochenkov · commit c0f49a9995d8 · 2024-01-30T15:00:52.000+03:00
The query accept arbitrary DefIds, not just owner DefIds.
The return can be an `Option` because if there are no nodes, then it doesn't matter whether it's due to NonOwner or Phantom.
Also rename the query to `opt_hir_owner_nodes`.
diff --git a/clippy_lints/src/min_ident_chars.rs b/clippy_lints/src/min_ident_chars.rs
@@ -93,7 +93,7 @@ impl Visitor<'_> for IdentVisitor<'_, '_> {
             // reimplement it even if we wanted to
             cx.tcx.opt_hir_node(hir_id)
         } else {
-            let Some(owner) = cx.tcx.hir_owner_nodes(hir_id.owner).as_owner() else {
+            let Some(owner) = cx.tcx.opt_hir_owner_nodes(hir_id.owner) else {
                 return;
             };
             owner.nodes.get(hir_id.local_id).copied().flatten().map(|p| p.node)
