Fix storing of stdout/stderr in bootstrap commands that failed to start

Kobzol · Kobzol · commit abd8768768cf · 2024-07-26T09:17:34.000+02:00
Before, their stdout/stderr was forcefully set to `None`, even if the corresponding command tried to capture output.
diff --git a/src/bootstrap/src/lib.rs b/src/bootstrap/src/lib.rs
@@ -1005,7 +1005,7 @@ Executed at: {executed_at}"#,
             \nIt was not possible to execute the command: {e:?}"
                 )
                 .unwrap();
-                CommandOutput::did_not_start()
+                CommandOutput::did_not_start(stdout, stderr)
             }
         };
         if !output.is_success() {
diff --git a/src/bootstrap/src/utils/exec.rs b/src/bootstrap/src/utils/exec.rs
@@ -231,8 +231,18 @@ pub struct CommandOutput {
 
 impl CommandOutput {
     #[must_use]
-    pub fn did_not_start() -> Self {
-        Self { status: CommandStatus::DidNotStart, stdout: None, stderr: None }
+    pub fn did_not_start(stdout: OutputMode, stderr: OutputMode) -> Self {
+        Self {
+            status: CommandStatus::DidNotStart,
+            stdout: match stdout {
+                OutputMode::Print => None,
+                OutputMode::Capture => Some(vec![]),
+            },
+            stderr: match stderr {
+                OutputMode::Print => None,
+                OutputMode::Capture => Some(vec![]),
+            },
+        }
     }
 
     #[must_use]

Original file line number	Diff line number	Diff line change
`@@ -1005,7 +1005,7 @@ Executed at: {executed_at}"#,`
`1005`	`1005`	`\nIt was not possible to execute the command: {e:?}"`
`1006`	`1006`	`)`
`1007`	`1007`	`.unwrap();`
`1008`		`- CommandOutput::did_not_start()`
	`1008`	`+ CommandOutput::did_not_start(stdout, stderr)`
`1009`	`1009`	`}`
`1010`	`1010`	`};`
`1011`	`1011`	`if !output.is_success() {`