Auto merge of #17456 - panicbit:remove-cargo-extension-warning, r=Veykril

bors · bors · commit a17efb9ec9ff · 2024-06-20T08:25:30.000Z
Remove panicbit.cargo extension warning

A warning was introduced regarding the incompatabilities between `rust-analyzer` and `panicbit.cargo`'s diagnostics / `cargo check` functionality.

This functionality has been removed in the latest version of the cargo extension (`0.3.0`), which is why the warning can be removed now.
diff --git a/src/tools/rust-analyzer/editors/code/src/main.ts b/src/tools/rust-analyzer/editors/code/src/main.ts
@@ -204,14 +204,4 @@ function checkConflictingExtensions() {
             )
             .then(() => {}, console.error);
     }
-
-    if (vscode.extensions.getExtension("panicbit.cargo")) {
-        vscode.window
-            .showWarningMessage(
-                `You have both the rust-analyzer (rust-lang.rust-analyzer) and Cargo (panicbit.cargo) plugins enabled, ` +
-                    'you can disable it or set {"cargo.automaticCheck": false} in settings.json to avoid invoking cargo twice',
-                "Got it",
-            )
-            .then(() => {}, console.error);
-    }
 }

Original file line number	Diff line number	Diff line change
`@@ -204,14 +204,4 @@ function checkConflictingExtensions() {`
`204`	`204`	`)`
`205`	`205`	`.then(() => {}, console.error);`
`206`	`206`	`}`
`207`		`-`
`208`		`- if (vscode.extensions.getExtension("panicbit.cargo")) {`
`209`		`- vscode.window`
`210`		`- .showWarningMessage(`
`211`		- `You have both the rust-analyzer (rust-lang.rust-analyzer) and Cargo (panicbit.cargo) plugins enabled, ` +
`212`		`- 'you can disable it or set {"cargo.automaticCheck": false} in settings.json to avoid invoking cargo twice',`
`213`		`- "Got it",`
`214`		`- )`
`215`		`- .then(() => {}, console.error);`
`216`		`- }`
`217`	`207`	`}`