Skip to content

Commit a0e31a5

Browse files
borsbors
authored
Auto merge of #36894 - petrochenkov:deny, r=nikomatsakis
Make sufficiently old or low-impact compatibility lints deny-by-default Tracking issues are updated/created when necessary. Needs crater run before proceeding. r? @nikomatsakis
2 parents 46d39f3 + 2a85211 commit a0e31a5

File tree

9 files changed

+32
-46
lines changed

9 files changed

+32
-46
lines changed

‎src/librustc/lint/builtin.rs

+7-7
Original file line numberDiff line numberDiff line change
@@ -120,25 +120,25 @@ declare_lint! {
120120

121121
declare_lint! {
122122
pub INACCESSIBLE_EXTERN_CRATE,
123-
Warn,
123+
Deny,
124124
"use of inaccessible extern crate erroneously allowed"
125125
}
126126

127127
declare_lint! {
128128
pub INVALID_TYPE_PARAM_DEFAULT,
129-
Warn,
129+
Deny,
130130
"type parameter default erroneously allowed in invalid location"
131131
}
132132

133133
declare_lint! {
134134
pub ILLEGAL_FLOATING_POINT_CONSTANT_PATTERN,
135-
Warn,
135+
Deny,
136136
"floating-point constants cannot be used in patterns"
137137
}
138138

139139
declare_lint! {
140140
pub ILLEGAL_STRUCT_OR_ENUM_CONSTANT_PATTERN,
141-
Warn,
141+
Deny,
142142
"constants of struct or enum type can only be used in a pattern if \
143143
the struct or enum has `#[derive(PartialEq, Eq)]`"
144144
}
@@ -164,7 +164,7 @@ declare_lint! {
164164

165165
declare_lint! {
166166
pub OVERLAPPING_INHERENT_IMPLS,
167-
Warn,
167+
Deny,
168168
"two overlapping inherent impls define an item with the same name were erroneously allowed"
169169
}
170170

@@ -176,13 +176,13 @@ declare_lint! {
176176

177177
declare_lint! {
178178
pub SUPER_OR_SELF_IN_GLOBAL_PATH,
179-
Warn,
179+
Deny,
180180
"detects super or self keywords at the beginning of global path"
181181
}
182182

183183
declare_lint! {
184184
pub LIFETIME_UNDERSCORE,
185-
Warn,
185+
Deny,
186186
"lifetimes or labels named `'_` were erroneously allowed"
187187
}
188188

‎src/librustc_const_eval/diagnostics.rs

-2
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@ Not-a-Number (NaN) values cannot be compared for equality and hence can never
7676
match the input to a match expression. So, the following will not compile:
7777
7878
```compile_fail
79-
#![deny(illegal_floating_point_constant_pattern)]
80-
8179
const NAN: f32 = 0.0 / 0.0;
8280
8381
let number = 0.1f32;

‎src/librustc_lint/lib.rs

+8-8
Original file line numberDiff line numberDiff line change
@@ -187,43 +187,43 @@ pub fn register_builtins(store: &mut lint::LintStore, sess: Option<&Session>) {
187187
},
188188
FutureIncompatibleInfo {
189189
id: LintId::of(INACCESSIBLE_EXTERN_CRATE),
190-
reference: "PR 31362 <https://github.com/rust-lang/rust/pull/31362>",
190+
reference: "issue #36886 <https://github.com/rust-lang/rust/issues/36886>",
191191
},
192192
FutureIncompatibleInfo {
193193
id: LintId::of(INVALID_TYPE_PARAM_DEFAULT),
194-
reference: "PR 30724 <https://github.com/rust-lang/rust/pull/30724>",
194+
reference: "issue #36887 <https://github.com/rust-lang/rust/issues/36887>",
195195
},
196196
FutureIncompatibleInfo {
197197
id: LintId::of(SUPER_OR_SELF_IN_GLOBAL_PATH),
198-
reference: "PR #32403 <https://github.com/rust-lang/rust/pull/32403>",
198+
reference: "issue #36888 <https://github.com/rust-lang/rust/issues/36888>",
199199
},
200200
FutureIncompatibleInfo {
201201
id: LintId::of(TRANSMUTE_FROM_FN_ITEM_TYPES),
202202
reference: "issue #19925 <https://github.com/rust-lang/rust/issues/19925>",
203203
},
204204
FutureIncompatibleInfo {
205205
id: LintId::of(OVERLAPPING_INHERENT_IMPLS),
206-
reference: "issue #22889 <https://github.com/rust-lang/rust/issues/22889>",
206+
reference: "issue #36889 <https://github.com/rust-lang/rust/issues/36889>",
207207
},
208208
FutureIncompatibleInfo {
209209
id: LintId::of(ILLEGAL_FLOATING_POINT_CONSTANT_PATTERN),
210-
reference: "RFC 1445 <https://github.com/rust-lang/rfcs/pull/1445>",
210+
reference: "issue #36890 <https://github.com/rust-lang/rust/issues/36890>",
211211
},
212212
FutureIncompatibleInfo {
213213
id: LintId::of(ILLEGAL_STRUCT_OR_ENUM_CONSTANT_PATTERN),
214-
reference: "RFC 1445 <https://github.com/rust-lang/rfcs/pull/1445>",
214+
reference: "issue #36891 <https://github.com/rust-lang/rust/issues/36891>",
215215
},
216216
FutureIncompatibleInfo {
217217
id: LintId::of(HR_LIFETIME_IN_ASSOC_TYPE),
218218
reference: "issue #33685 <https://github.com/rust-lang/rust/issues/33685>",
219219
},
220220
FutureIncompatibleInfo {
221221
id: LintId::of(LIFETIME_UNDERSCORE),
222-
reference: "RFC 1177 <https://github.com/rust-lang/rfcs/pull/1177>",
222+
reference: "issue #36892 <https://github.com/rust-lang/rust/issues/36892>",
223223
},
224224
FutureIncompatibleInfo {
225225
id: LintId::of(SAFE_EXTERN_STATICS),
226-
reference: "issue 36247 <https://github.com/rust-lang/rust/issues/35112>",
226+
reference: "issue #36247 <https://github.com/rust-lang/rust/issues/35112>",
227227
},
228228
]);
229229

‎src/test/compile-fail/extern-crate-visibility.rs

+4-7
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
#![feature(rustc_attrs)]
12-
#![allow(dead_code)]
13-
#![allow(unused_imports)]
11+
#![allow(unused)]
1412

1513
mod foo {
1614
extern crate core;
@@ -19,11 +17,11 @@ mod foo {
1917
// Check that private crates can be used from outside their modules, albeit with warnings
2018
use foo::core; //~ WARN extern crate `core` is private
2119
//~^ WARN this was previously accepted by the compiler but is being phased out
22-
use foo::core::cell; //~ WARN extern crate `core` is private
20+
use foo::core::cell; //~ ERROR extern crate `core` is private
2321
//~^ WARN this was previously accepted by the compiler but is being phased out
2422

2523
fn f() {
26-
foo::core::cell::Cell::new(0); //~ WARN extern crate `core` is private
24+
foo::core::cell::Cell::new(0); //~ ERROR extern crate `core` is private
2725
//~^ WARN this was previously accepted by the compiler but is being phased out
2826

2927
use foo::*;
@@ -39,5 +37,4 @@ mod baz {
3937
use self::core::cell; // Check that public extern crates are glob imported
4038
}
4139

42-
#[rustc_error]
43-
fn main() {} //~ ERROR compilation successful
40+
fn main() {}

‎src/test/compile-fail/inherent-overlap.rs

+5-7
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,12 @@
1111
// Test that you cannot define items with the same name in overlapping inherent
1212
// impl blocks.
1313

14-
#![feature(rustc_attrs)]
15-
#![allow(dead_code)]
14+
#![allow(unused)]
1615

1716
struct Foo;
1817

1918
impl Foo {
20-
fn id() {} //~ WARN duplicate definitions
19+
fn id() {} //~ ERROR duplicate definitions
2120
//~^ WARN previously accepted
2221
}
2322

@@ -28,7 +27,7 @@ impl Foo {
2827
struct Bar<T>(T);
2928

3029
impl<T> Bar<T> {
31-
fn bar(&self) {} //~ WARN duplicate definitions
30+
fn bar(&self) {} //~ ERROR duplicate definitions
3231
//~^ WARN previously accepted
3332
}
3433

@@ -39,13 +38,12 @@ impl Bar<u32> {
3938
struct Baz<T>(T);
4039

4140
impl<T: Copy> Baz<T> {
42-
fn baz(&self) {} //~ WARN duplicate definitions
41+
fn baz(&self) {} //~ ERROR duplicate definitions
4342
//~^ WARN previously accepted
4443
}
4544

4645
impl<T> Baz<Vec<T>> {
4746
fn baz(&self) {}
4847
}
4948

50-
#[rustc_error]
51-
fn main() {} //~ ERROR compilation successful
49+
fn main() {}

‎src/test/compile-fail/issue-6804.rs

+3-6
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,13 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
#![feature(rustc_attrs)]
12-
#![feature(slice_patterns)]
13-
#![allow(dead_code)]
14-
#![deny(illegal_floating_point_constant_pattern)]
15-
1611
// Matching against NaN should result in a warning
1712

13+
#![feature(slice_patterns)]
14+
#![allow(unused)]
15+
1816
use std::f64::NAN;
1917

20-
#[rustc_error]
2118
fn main() {
2219
let x = NAN;
2320
match x {

‎src/test/compile-fail/lifetime-underscore.rs

-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
#![deny(lifetime_underscore)]
12-
1311
fn _f<'_>() //~ ERROR invalid lifetime name `'_`
1412
//~^ WARN this was previously accepted
1513
-> &'_ u8 //~ ERROR invalid lifetime name `'_`

‎src/test/compile-fail/use-super-global-path.rs

+4-6
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,20 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
#![feature(rustc_attrs)]
12-
#![allow(unused_imports, dead_code)]
11+
#![allow(unused)]
1312

1413
struct S;
1514
struct Z;
1615

1716
mod foo {
18-
use ::super::{S, Z}; //~ WARN global paths cannot start with `super`
17+
use ::super::{S, Z}; //~ ERROR global paths cannot start with `super`
1918
//~^ WARN this was previously accepted by the compiler but is being phased out
2019

2120
pub fn g() {
22-
use ::super::main; //~ WARN global paths cannot start with `super`
21+
use ::super::main; //~ ERROR global paths cannot start with `super`
2322
//~^ WARN this was previously accepted by the compiler but is being phased out
2423
main();
2524
}
2625
}
2726

28-
#[rustc_error]
29-
fn main() { foo::g(); } //~ ERROR compilation successful
27+
fn main() { foo::g(); }

‎src/test/run-pass/type-macros-simple.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ fn issue_36540() {
2323

2424
let x: m!() = m!();
2525
std::cell::Cell::<m!()>::new(m!());
26-
impl<T = m!()> std::ops::Index<m!()> for Trait<(m!(), T)>
26+
impl<T> std::ops::Index<m!()> for Trait<(m!(), T)>
2727
where T: Trait<m!()>
2828
{
2929
type Output = m!();

0 commit comments

Comments
 (0)