Skip to content

Commit 9f36ec0

Browse files
committedApr 29, 2015
Use PIE on Android
This is OK to do given: - PIE is supported on Android starting with API 16. - The bots are running API 18. - API < 16 now has a 12.5% market share[0] as of 2015-04-29. Unfortunately, this breaks backtrace support. See #17520. Closes #17437. [0] https://developer.android.com/about/dashboards/index.html
1 parent 7e2b093 commit 9f36ec0

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed
 

‎src/librustc_back/target/arm_linux_androideabi.rs

-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ use target::Target;
1313
pub fn target() -> Target {
1414
let mut base = super::android_base::opts();
1515
base.features = "+v7".to_string();
16-
// FIXME #17437 (and #17448): Android doesn't support position dependent executables anymore.
17-
base.position_independent_executables = false;
1816

1917
Target {
2018
data_layout: "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-\

‎src/test/run-pass/backtrace.rs

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
// no-pretty-expanded FIXME #15189
1212
// ignore-windows FIXME #13259
13+
// ignore-android FIXME #17520
1314

1415
use std::env;
1516
use std::process::{Command, Stdio};

0 commit comments

Comments
 (0)