Skip to content

Commit 91b3ef5

Browse files
committed
Notify T-rustdoc for beta-accepted and stable-accepted too
Otherwise, it's unclear when the nomination label is removed whether the backport was accepted, thus nomination removed, or if the backport was rejected, thus nomination removed.
1 parent 72d8d8d commit 91b3ef5

File tree

1 file changed

+26
-0
lines changed

1 file changed

+26
-0
lines changed

triagebot.toml

+26
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,19 @@ message_on_remove = "PR #{number}'s beta-nomination has been removed."
452452
message_on_close = "PR #{number} has been closed. Thanks for participating!"
453453
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
454454

455+
# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
456+
# At the moment, the beta-accepted+T-rustdoc action fully occupies the beta-accepted slot
457+
# preventing others from adding more beta-accepted actions.
458+
[notify-zulip."beta-accepted"]
459+
required_labels = ["T-rustdoc"]
460+
zulip_stream = 266220 # #t-rustdoc
461+
# Put it in the same thread as beta-nominated.
462+
topic = "beta-nominated: #{number}"
463+
message_on_add = "PR #{number} has been **accepted** for beta backport."
464+
message_on_remove = "PR #{number}'s beta-acceptance has been **removed**."
465+
message_on_close = "PR #{number} has been closed. Thanks for participating!"
466+
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
467+
455468
# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
456469
# At the moment, the stable-nominated+T-rustdoc action fully occupies the stable-nominated slot
457470
# preventing others from adding more stable-nominated actions.
@@ -476,6 +489,19 @@ message_on_remove = "PR #{number}'s stable-nomination has been removed."
476489
message_on_close = "PR #{number} has been closed. Thanks for participating!"
477490
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
478491

492+
# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
493+
# At the moment, the stable-accepted+T-rustdoc action fully occupies the stable-accepted slot
494+
# preventing others from adding more stable-accepted actions.
495+
[notify-zulip."stable-accepted"]
496+
required_labels = ["T-rustdoc"]
497+
zulip_stream = 266220 # #t-rustdoc
498+
# Put it in the same thread as stable-nominated.
499+
topic = "stable-nominated: #{number}"
500+
message_on_add = "PR #{number} has been **accepted** for stable backport."
501+
message_on_remove = "PR #{number}'s stable-acceptance has been **removed**."
502+
message_on_close = "PR #{number} has been closed. Thanks for participating!"
503+
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
504+
479505
[notify-zulip."I-types-nominated"]
480506
zulip_stream = 326866 # #T-types/nominated
481507
topic = "#{number}: {title}"

0 commit comments

Comments
 (0)