This check should now be unreachable

oli-obk · oli-obk · commit 814bfe9335fd · 2024-07-01T10:35:16.000Z
diff --git a/compiler/rustc_hir_typeck/src/expr_use_visitor.rs b/compiler/rustc_hir_typeck/src/expr_use_visitor.rs
@@ -734,9 +734,7 @@ impl<'tcx, Cx: TypeInformationCtxt<'tcx>, D: Delegate<'tcx>> ExprUseVisitor<'tcx
                 // struct; however, when EUV is run during typeck, it
                 // may not. This will generate an error earlier in typeck,
                 // so we can just ignore it.
-                if self.cx.tcx().dcx().has_errors().is_none() {
-                    span_bug!(with_expr.span, "with expression doesn't evaluate to a struct");
-                }
+                span_bug!(with_expr.span, "with expression doesn't evaluate to a struct");
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -734,9 +734,7 @@ impl<'tcx, Cx: TypeInformationCtxt<'tcx>, D: Delegate<'tcx>> ExprUseVisitor<'tcx`
`734`	`734`	`// struct; however, when EUV is run during typeck, it`
`735`	`735`	`// may not. This will generate an error earlier in typeck,`
`736`	`736`	`// so we can just ignore it.`
`737`		`- if self.cx.tcx().dcx().has_errors().is_none() {`
`738`		`- span_bug!(with_expr.span, "with expression doesn't evaluate to a struct");`
`739`		`- }`
	`737`	`+ span_bug!(with_expr.span, "with expression doesn't evaluate to a struct");`
`740`	`738`	`}`
`741`	`739`	`}`
`742`	`740`