Do not run check on foreign items.

cjgillot · cjgillot · commit 7fd2d8d21bb6 · 2023-12-31T00:22:52.000Z
diff --git a/compiler/rustc_hir_analysis/src/collect/type_of/opaque.rs b/compiler/rustc_hir_analysis/src/collect/type_of/opaque.rs
@@ -244,7 +244,7 @@ impl<'tcx> intravisit::Visitor<'tcx> for TaitConstraintLocator<'tcx> {
     fn visit_foreign_item(&mut self, it: &'tcx hir::ForeignItem<'tcx>) {
         trace!(?it.owner_id);
         assert_ne!(it.owner_id.def_id, self.def_id);
-        self.check(it.owner_id.def_id);
+        // No need to call `check`, as we do not run borrowck on foreign items.
         intravisit::walk_foreign_item(self, it);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ impl<'tcx> intravisit::Visitor<'tcx> for TaitConstraintLocator<'tcx> {`
`244`	`244`	`fn visit_foreign_item(&mut self, it: &'tcx hir::ForeignItem<'tcx>) {`
`245`	`245`	`trace!(?it.owner_id);`
`246`	`246`	`assert_ne!(it.owner_id.def_id, self.def_id);`
`247`		`- self.check(it.owner_id.def_id);`
	`247`	+ // No need to call `check`, as we do not run borrowck on foreign items.
`248`	`248`	`intravisit::walk_foreign_item(self, it);`
`249`	`249`	`}`
`250`	`250`	`}`