Explain explicit slicing in slice cmp and partial_cmp methods

ranma42 · ranma42 · commit 74dc146f4296 · 2015-09-16T16:09:23.000+02:00
The explicit slicing is needed in order to enable additional range
check optimizations in the compiler.
diff --git a/src/libcore/slice.rs b/src/libcore/slice.rs
@@ -1560,6 +1560,9 @@ impl<T: Eq> Eq for [T] {}
 impl<T: Ord> Ord for [T] {
     fn cmp(&self, other: &[T]) -> Ordering {
         let l = cmp::min(self.len(), other.len());
+
+        // Slice to the loop iteration range to enable bound check
+        // elimination in the compiler
         let lhs = &self[..l];
         let rhs = &other[..l];
 
@@ -1578,6 +1581,9 @@ impl<T: Ord> Ord for [T] {
 impl<T: PartialOrd> PartialOrd for [T] {
     fn partial_cmp(&self, other: &[T]) -> Option<Ordering> {
         let l = cmp::min(self.len(), other.len());
+
+        // Slice to the loop iteration range to enable bound check
+        // elimination in the compiler
         let lhs = &self[..l];
         let rhs = &other[..l];
 
