Fallback to dladdr-based resolve_symbol if backtrace failed.

kennytm · kennytm · commit 7169fe57d66d · 2017-09-02T03:24:17.000+08:00
This programs compiled without -g on macOS still provide the resolve to
actual symbols, instead of `&lt;unknown&gt;` everywhere.
diff --git a/src/libstd/sys/unix/backtrace/printing/dladdr.rs b/src/libstd/sys/unix/backtrace/printing/dladdr.rs
@@ -31,14 +31,6 @@ pub fn resolve_symname<F>(frame: Frame,
     }
 }
 
-pub fn foreach_symbol_fileline<F>(_symbol_addr: Frame,
-                                  _f: F,
-                                  _: &BacktraceContext) -> io::Result<bool>
-    where F: FnMut(&[u8], libc::c_int) -> io::Result<()>
-{
-    Ok(false)
-}
-
 #[repr(C)]
 struct Dl_info {
     dli_fname: *const libc::c_char,
diff --git a/src/libstd/sys/unix/backtrace/printing/mod.rs b/src/libstd/sys/unix/backtrace/printing/mod.rs
@@ -1,4 +1,4 @@
-// Copyright 2014-2015 The Rust Project Developers. See the COPYRIGHT
+// Copyright 2014-2017 The Rust Project Developers. See the COPYRIGHT
 // file at the top-level directory of this distribution and at
 // http://rust-lang.org/COPYRIGHT.
 //
@@ -8,13 +8,36 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-pub use self::imp::{foreach_symbol_fileline, resolve_symname};
+mod dladdr;
+
+use sys::backtrace::BacktraceContext;
+use sys_common::backtrace::Frame;
+use io;
+
+#[cfg(target_os = "emscripten")]
+pub use self::dladdr::resolve_symname;
 
 #[cfg(target_os = "emscripten")]
-#[path = "dladdr.rs"]
-mod imp;
+pub fn foreach_symbol_fileline<F>(_: Frame, _: F, _: &BacktraceContext) -> io::Result<bool>
+where
+    F: FnMut(&[u8], ::libc::c_int) -> io::Result<()>
+{
+    Ok(false)
+}
+
+#[cfg(not(target_os = "emscripten"))]
+pub use sys_common::gnu::libbacktrace::foreach_symbol_fileline;
 
 #[cfg(not(target_os = "emscripten"))]
-mod imp {
-    pub use sys_common::gnu::libbacktrace::{foreach_symbol_fileline, resolve_symname};
+pub fn resolve_symname<F>(frame: Frame, callback: F, bc: &BacktraceContext) -> io::Result<()>
+where
+    F: FnOnce(Option<&str>) -> io::Result<()>
+{
+    ::sys_common::gnu::libbacktrace::resolve_symname(frame, |symname| {
+        if symname.is_some() {
+            callback(symname)
+        } else {
+            dladdr::resolve_symname(frame, callback, bc)
+        }
+    }, bc)
 }

Original file line number	Diff line number	Diff line change
`@@ -31,14 +31,6 @@ pub fn resolve_symname<F>(frame: Frame,`
`31`	`31`	`}`
`32`	`32`	`}`
`33`	`33`
`34`		`-pub fn foreach_symbol_fileline<F>(_symbol_addr: Frame,`
`35`		`- _f: F,`
`36`		`- _: &BacktraceContext) -> io::Result<bool>`
`37`		`- where F: FnMut(&[u8], libc::c_int) -> io::Result<()>`
`38`		`-{`
`39`		`- Ok(false)`
`40`		`-}`
`41`		`-`
`42`	`34`	`#[repr(C)]`
`43`	`35`	`struct Dl_info {`
`44`	`36`	`dli_fname: *const libc::c_char,`