Split Handler::emit_diagnostic in two.

nnethercote · nnethercote · commit 7045cad33073 · 2023-12-15T10:13:12.000+11:00
Currently, `emit_diagnostic` takes `&amp;mut self`.

This commit changes it so `emit_diagnostic` takes `self` and the new
`emit_diagnostic_without_consuming` function takes `&amp;mut self`.

I find the distinction useful. The former case is much more common, and
avoids a bunch of `mut` and `&amp;mut` occurrences. We can also restrict the
latter with `pub(crate)` which is nice.
diff --git a/src/parse/session.rs b/src/parse/session.rs
@@ -284,10 +284,8 @@ impl ParseSess {
 // Methods that should be restricted within the parse module.
 impl ParseSess {
     pub(super) fn emit_diagnostics(&self, diagnostics: Vec<Diagnostic>) {
-        for mut diagnostic in diagnostics {
-            self.parse_sess
-                .span_diagnostic
-                .emit_diagnostic(&mut diagnostic);
+        for diagnostic in diagnostics {
+            self.parse_sess.span_diagnostic.emit_diagnostic(diagnostic);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -284,10 +284,8 @@ impl ParseSess {`
`284`	`284`	`// Methods that should be restricted within the parse module.`
`285`	`285`	`impl ParseSess {`
`286`	`286`	`pub(super) fn emit_diagnostics(&self, diagnostics: Vec<Diagnostic>) {`
`287`		`- for mut diagnostic in diagnostics {`
`288`		`- self.parse_sess`
`289`		`- .span_diagnostic`
`290`		`- .emit_diagnostic(&mut diagnostic);`
	`287`	`+ for diagnostic in diagnostics {`
	`288`	`+ self.parse_sess.span_diagnostic.emit_diagnostic(diagnostic);`
`291`	`289`	`}`
`292`	`290`	`}`
`293`	`291`