fix: skip container header if no generics params

roife · roife · commit 6c122f699010 · 2024-06-11T21:02:13.000+08:00
diff --git a/src/tools/rust-analyzer/crates/hir/src/display.rs b/src/tools/rust-analyzer/crates/hir/src/display.rs
@@ -36,13 +36,13 @@ impl HirDisplay for Function {
 
         match container {
             Some(AssocItemContainer::Trait(trait_)) => {
-                if f.show_container_bounds() {
+                if f.show_container_bounds() && !f.db.generic_params(trait_.id.into()).is_empty() {
                     write_trait_header(&trait_, f)?;
                     f.write_str("\n")?;
                 }
             }
             Some(AssocItemContainer::Impl(impl_)) => {
-                if f.show_container_bounds() {
+                if f.show_container_bounds() && !f.db.generic_params(impl_.id.into()).is_empty() {
                     write_impl_header(&impl_, f)?;
                     f.write_str("\n")?;
                 }

Original file line number	Diff line number	Diff line change
`@@ -36,13 +36,13 @@ impl HirDisplay for Function {`
`36`	`36`
`37`	`37`	`match container {`
`38`	`38`	`Some(AssocItemContainer::Trait(trait_)) => {`
`39`		`- if f.show_container_bounds() {`
	`39`	`+ if f.show_container_bounds() && !f.db.generic_params(trait_.id.into()).is_empty() {`
`40`	`40`	`write_trait_header(&trait_, f)?;`
`41`	`41`	`f.write_str("\n")?;`
`42`	`42`	`}`
`43`	`43`	`}`
`44`	`44`	`Some(AssocItemContainer::Impl(impl_)) => {`
`45`		`- if f.show_container_bounds() {`
	`45`	`+ if f.show_container_bounds() && !f.db.generic_params(impl_.id.into()).is_empty() {`
`46`	`46`	`write_impl_header(&impl_, f)?;`
`47`	`47`	`f.write_str("\n")?;`
`48`	`48`	`}`