Allow ignoring the failure of command execution

Kobzol · Kobzol · commit 5d7fca15d3c7 · 2023-10-26T21:52:48.000+02:00
diff --git a/src/bootstrap/src/core/build_steps/test.rs b/src/bootstrap/src/core/build_steps/test.rs
@@ -810,7 +810,7 @@ impl Step for Clippy {
         let _guard = builder.msg_sysroot_tool(Kind::Test, compiler.stage, "clippy", host, host);
 
         // Clippy reports errors if it blessed the outputs
-        if builder.run_cmd(&mut cargo) {
+        if builder.run_cmd(BootstrapCommand::from(&mut cargo).allow_failure()) {
             // The tests succeeded; nothing to do.
             return;
         }
diff --git a/src/bootstrap/src/core/build_steps/tool.rs b/src/bootstrap/src/core/build_steps/tool.rs
@@ -8,6 +8,7 @@ use crate::core::build_steps::toolstate::ToolState;
 use crate::core::builder::{Builder, Cargo as CargoCommand, RunConfig, ShouldRun, Step};
 use crate::core::config::TargetSelection;
 use crate::utils::channel::GitInfo;
+use crate::utils::exec::BootstrapCommand;
 use crate::utils::helpers::{add_dylib_path, exe, t};
 use crate::Compiler;
 use crate::Mode;
@@ -109,7 +110,7 @@ impl Step for ToolBuild {
 
         let mut cargo = Command::from(cargo);
         // we check this in `is_optional_tool` in a second
-        let is_expected = builder.run_cmd(&mut cargo);
+        let is_expected = builder.run_cmd(BootstrapCommand::from(&mut cargo).allow_failure());
 
         builder.save_toolstate(
             tool,
diff --git a/src/bootstrap/src/lib.rs b/src/bootstrap/src/lib.rs
@@ -581,9 +581,12 @@ impl Build {
         // Save any local changes, but avoid running `git stash pop` if there are none (since it will exit with an error).
         // diff-index reports the modifications through the exit status
         let has_local_modifications = !self.run_cmd(
-            Command::new("git")
-                .args(&["diff-index", "--quiet", "HEAD"])
-                .current_dir(&absolute_path),
+            BootstrapCommand::from(
+                Command::new("git")
+                    .args(&["diff-index", "--quiet", "HEAD"])
+                    .current_dir(&absolute_path),
+            )
+            .allow_failure(),
         );
         if has_local_modifications {
             self.run(Command::new("git").args(&["stash", "push"]).current_dir(&absolute_path));
@@ -1009,6 +1012,7 @@ impl Build {
                     BehaviorOnFailure::Exit => {
                         exit!(1);
                     }
+                    BehaviorOnFailure::Ignore => {}
                 }
                 false
             }
diff --git a/src/bootstrap/src/utils/exec.rs b/src/bootstrap/src/utils/exec.rs
@@ -7,6 +7,8 @@ pub enum BehaviorOnFailure {
     Exit,
     /// Delay failure until the end of bootstrap invocation.
     DelayFail,
+    /// Ignore the failure, the command can fail in an expected way.
+    Ignore,
 }
 
 /// How should the output of the command be handled.
@@ -33,9 +35,15 @@ impl<'a> BootstrapCommand<'a> {
     pub fn delay_failure(self) -> Self {
         Self { failure_behavior: BehaviorOnFailure::DelayFail, ..self }
     }
+
     pub fn fail_fast(self) -> Self {
         Self { failure_behavior: BehaviorOnFailure::Exit, ..self }
     }
+
+    pub fn allow_failure(self) -> Self {
+        Self { failure_behavior: BehaviorOnFailure::Ignore, ..self }
+    }
+
     pub fn output_mode(self, output_mode: OutputMode) -> Self {
         Self { output_mode, ..self }
     }

Original file line number	Diff line number	Diff line change
`@@ -810,7 +810,7 @@ impl Step for Clippy {`
`810`	`810`	`let _guard = builder.msg_sysroot_tool(Kind::Test, compiler.stage, "clippy", host, host);`
`811`	`811`
`812`	`812`	`// Clippy reports errors if it blessed the outputs`
`813`		`- if builder.run_cmd(&mut cargo) {`
	`813`	`+ if builder.run_cmd(BootstrapCommand::from(&mut cargo).allow_failure()) {`
`814`	`814`	`// The tests succeeded; nothing to do.`
`815`	`815`	`return;`
`816`	`816`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,8 @@ pub enum BehaviorOnFailure {`
`7`	`7`	`Exit,`
`8`	`8`	`/// Delay failure until the end of bootstrap invocation.`
`9`	`9`	`DelayFail,`
	`10`	`+ /// Ignore the failure, the command can fail in an expected way.`
	`11`	`+ Ignore,`
`10`	`12`	`}`
`11`	`13`
`12`	`14`	`/// How should the output of the command be handled.`
`@@ -33,9 +35,15 @@ impl<'a> BootstrapCommand<'a> {`
`33`	`35`	`pub fn delay_failure(self) -> Self {`
`34`	`36`	`Self { failure_behavior: BehaviorOnFailure::DelayFail, ..self }`
`35`	`37`	`}`
	`38`	`+`
`36`	`39`	`pub fn fail_fast(self) -> Self {`
`37`	`40`	`Self { failure_behavior: BehaviorOnFailure::Exit, ..self }`
`38`	`41`	`}`
	`42`	`+`
	`43`	`+ pub fn allow_failure(self) -> Self {`
	`44`	`+ Self { failure_behavior: BehaviorOnFailure::Ignore, ..self }`
	`45`	`+ }`
	`46`	`+`
`39`	`47`	`pub fn output_mode(self, output_mode: OutputMode) -> Self {`
`40`	`48`	`Self { output_mode, ..self }`
`41`	`49`	`}`