Remove effect of #[no_link] attribute on name resolution

petrochenkov · petrochenkov · commit 54cd82481905 · 2021-12-17T20:14:30.000+08:00
Previously it hid all non-macro names from other crates.
This has no relation to linking and can change name resolution behavior in some cases (e.g. glob conflicts), in addition to just producing the "unresolved name" errors
diff --git a/compiler/rustc_metadata/src/rmeta/decoder.rs b/compiler/rustc_metadata/src/rmeta/decoder.rs
@@ -1099,10 +1099,7 @@ impl<'a, 'tcx> CrateMetadataRef<'a> {
         };
 
         // Iterate over all children.
-        let macros_only = self.dep_kind.lock().macros_only();
-        if !macros_only {
-            let children = self.root.tables.children.get(self, id).unwrap_or_else(Lazy::empty);
-
+        if let Some(children) = self.root.tables.children.get(self, id) {
             for child_index in children.decode((self, sess)) {
                 // Get the item.
                 let child_kind = match self.maybe_kind(child_index) {
@@ -1200,11 +1197,6 @@ impl<'a, 'tcx> CrateMetadataRef<'a> {
 
         if let EntryKind::Mod(exports) = kind {
             for exp in exports.decode((self, sess)) {
-                match exp.res {
-                    Res::Def(DefKind::Macro(..), _) => {}
-                    _ if macros_only => continue,
-                    _ => {}
-                }
                 callback(exp);
             }
         }
diff --git a/src/test/ui/no-link.rs b/src/test/ui/no-link.rs
@@ -1,8 +1,9 @@
+// check-pass
 // aux-build:empty-struct.rs
 
 #[no_link]
 extern crate empty_struct;
 
 fn main() {
-    empty_struct::XEmpty1; //~ ERROR cannot find value `XEmpty1` in crate `empty_struct`
+    empty_struct::XEmpty1 {};
 }
diff --git a/src/test/ui/no-link.stderr b/src/test/ui/no-link.stderr

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,9 @@`
	`1`	`+// check-pass`
`1`	`2`	`// aux-build:empty-struct.rs`
`2`	`3`
`3`	`4`	`#[no_link]`
`4`	`5`	`extern crate empty_struct;`
`5`	`6`
`6`	`7`	`fn main() {`
`7`		- empty_struct::XEmpty1; //~ ERROR cannot find value `XEmpty1` in crate `empty_struct`
	`8`	`+ empty_struct::XEmpty1 {};`
`8`	`9`	`}`