Auto merge of #17353 - roife:fix-issue-12728, r=Veykril

bors · bors · commit 4739660378c1 · 2024-06-06T13:49:08.000Z
fix: incorrect formatting of hover actions fix #12728. ### Changes - Use ` | ` as the separator for actions. (I'm not sure why we use `___` previously) - Reorder actions to match codelens
diff --git a/src/tools/rust-analyzer/crates/ide/src/hover.rs b/src/tools/rust-analyzer/crates/ide/src/hover.rs
@@ -375,8 +375,8 @@ pub(crate) fn hover_for_definition(
     HoverResult {
         markup: render::process_markup(sema.db, def, &markup, config),
         actions: [
-            show_implementations_action(sema.db, def),
             show_fn_references_action(sema.db, def),
+            show_implementations_action(sema.db, def),
             runnable_action(sema, def, file_id),
             goto_type_action_for_def(sema.db, def, &notable_traits),
         ]
diff --git a/src/tools/rust-analyzer/editors/code/src/client.ts b/src/tools/rust-analyzer/editors/code/src/client.ts
@@ -63,7 +63,7 @@ function renderHoverActions(actions: ra.CommandLinkGroup[]): vscode.MarkdownStri
                 (group.title ? group.title + " " : "") +
                 group.commands.map(renderCommand).join(" | "),
         )
-        .join("___");
+        .join(" | ");
 
     const result = new vscode.MarkdownString(text);
     result.isTrusted = true;

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ function renderHoverActions(actions: ra.CommandLinkGroup[]): vscode.MarkdownStri`
`63`	`63`	`(group.title ? group.title + " " : "") +`
`64`	`64`	`group.commands.map(renderCommand).join(" \| "),`
`65`	`65`	`)`
`66`		`- .join("___");`
	`66`	`+ .join(" \| ");`
`67`	`67`
`68`	`68`	`const result = new vscode.MarkdownString(text);`
`69`	`69`	`result.isTrusted = true;`