Rollup merge of #118981 - krtab:onelessalloc, r=compiler-errors

workingjubilee · web-flow · commit 3d94fc9dfe24 · 2023-12-15T14:08:17.000-08:00
Remove an unneeded allocation

This removes an unneeded allocation in `&lt;&amp;[hir::GenericParam&lt;'_&gt;] as NextTypeParamName&gt;::next_type_param_name`
diff --git a/compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs b/compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
@@ -4665,7 +4665,7 @@ pub trait NextTypeParamName {
 impl NextTypeParamName for &[hir::GenericParam<'_>] {
     fn next_type_param_name(&self, name: Option<&str>) -> String {
         // This is the list of possible parameter names that we might suggest.
-        let name = name.and_then(|n| n.chars().next()).map(|c| c.to_string().to_uppercase());
+        let name = name.and_then(|n| n.chars().next()).map(|c| c.to_uppercase().to_string());
         let name = name.as_deref();
         let possible_names = [name.unwrap_or("T"), "T", "U", "V", "X", "Y", "Z", "A", "B", "C"];
         let used_names = self
