Skip to content

Commit 3bff119

Browse files
flip1995flip1995
committed
Merge commit '3e5a02b13b1244545454752c6629b767522a44b1' into clippy-subtree-update
1 parent 35f54fd commit 3bff119

File tree

207 files changed

+3098
-1667
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

207 files changed

+3098
-1667
lines changed

‎CHANGELOG.md

+63-2
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,69 @@ document.
66

77
## Unreleased / Beta / In Rust Nightly
88

9-
[93f0a9a9...master](https://github.com/rust-lang/rust-clippy/compare/93f0a9a9...master)
9+
[ca3b3937...master](https://github.com/rust-lang/rust-clippy/compare/ca3b3937...master)
10+
11+
## Rust 1.79
12+
13+
Current stable, released 2024-06-13
14+
15+
[View all 102 merged pull requests](https://github.com/rust-lang/rust-clippy/pulls?q=merged%3A2024-03-08T11%3A13%3A58Z..2024-04-18T15%3A50%3A50Z+base%3Amaster)
16+
17+
### New Lints
18+
19+
* Added [`legacy_numeric_constants`] to `style`
20+
[#12312](https://github.com/rust-lang/rust-clippy/pull/12312)
21+
* Added [`missing_transmute_annotations`] to `suspicious`
22+
[#12239](https://github.com/rust-lang/rust-clippy/pull/12239)
23+
* Added [`integer_division_remainder_used`] to `restriction`
24+
[#12451](https://github.com/rust-lang/rust-clippy/pull/12451)
25+
* Added [`duplicated_attributes`] to `suspicious`
26+
[#12378](https://github.com/rust-lang/rust-clippy/pull/12378)
27+
* Added [`manual_unwrap_or_default`] to `suspicious`
28+
[#12440](https://github.com/rust-lang/rust-clippy/pull/12440)
29+
* Added [`zero_repeat_side_effects`] to `suspicious`
30+
[#12449](https://github.com/rust-lang/rust-clippy/pull/12449)
31+
* Added [`const_is_empty`] to `suspicious`
32+
[#12310](https://github.com/rust-lang/rust-clippy/pull/12310)
33+
34+
### Moves and Deprecations
35+
36+
* Moved [`box_default`] to `style` (From `perf`)
37+
[#12601](https://github.com/rust-lang/rust-clippy/pull/12601)
38+
* Moved [`manual_clamp`] to `complexity` (From `nursery` now warn-by-default)
39+
[#12543](https://github.com/rust-lang/rust-clippy/pull/12543)
40+
* Moved [`readonly_write_lock`] to `perf` (From `nursery` now warn-by-default)
41+
[#12479](https://github.com/rust-lang/rust-clippy/pull/12479)
42+
43+
### Enhancements
44+
45+
* [`module_name_repetitions`]: Added the [`allowed-prefixes`] configuration to allow common prefixes.
46+
[#12573](https://github.com/rust-lang/rust-clippy/pull/12573)
47+
* [`cast_sign_loss`], [`cast_possible_truncation`], [`cast_lossless`]: Are now allowed in macros
48+
[#12631](https://github.com/rust-lang/rust-clippy/pull/12631)
49+
* [`manual_clamp`]: Now only lints on constant min and max values
50+
[#12543](https://github.com/rust-lang/rust-clippy/pull/12543)
51+
* [`assigning_clones`]: Now considers the [`msrv`] configuration
52+
[#12511](https://github.com/rust-lang/rust-clippy/pull/12511)
53+
* [`needless_return`], [`useless_let_if_seq`], [`mut_mut`], [`read_zero_byte_vec`], [`unused_io_amount`],
54+
[`unused_peekable`]: Now respects `#[allow]` attributes on the affected statement instead
55+
[#12446](https://github.com/rust-lang/rust-clippy/pull/12446)
56+
57+
### False Positive Fixes
58+
59+
* [`cast_lossless`]: No longer lints when casting to `u128`
60+
[#12496](https://github.com/rust-lang/rust-clippy/pull/12496)
61+
* [`std_instead_of_core`] No longer lints on modules that are only in `std`
62+
[#12447](https://github.com/rust-lang/rust-clippy/pull/12447)
63+
64+
### ICE Fixes
65+
66+
* [`needless_return`]: No longer crashes on non-ascii characters
67+
[#12493](https://github.com/rust-lang/rust-clippy/pull/12493)
1068

1169
## Rust 1.78
1270

13-
Current stable, released 2024-05-02
71+
Released 2024-05-02
1472

1573
[View all 112 merged pull requests](https://github.com/rust-lang/rust-clippy/pulls?q=merged%3A2024-01-26T05%3A46%3A23Z..2024-03-07T16%3A25%3A52Z+base%3Amaster)
1674

@@ -5474,6 +5532,7 @@ Released 2018-09-13
54745532
[`manual_next_back`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_next_back
54755533
[`manual_non_exhaustive`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_non_exhaustive
54765534
[`manual_ok_or`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_or
5535+
[`manual_pattern_char_comparison`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
54775536
[`manual_range_contains`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
54785537
[`manual_range_patterns`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns
54795538
[`manual_rem_euclid`]: https://rust-lang.github.io/rust-clippy/master/index.html#manual_rem_euclid
@@ -5567,6 +5626,7 @@ Released 2018-09-13
55675626
[`needless_borrow`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
55685627
[`needless_borrowed_reference`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
55695628
[`needless_borrows_for_generic_args`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
5629+
[`needless_character_iteration`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_character_iteration
55705630
[`needless_collect`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
55715631
[`needless_continue`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue
55725632
[`needless_doctest_main`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main
@@ -5576,6 +5636,7 @@ Released 2018-09-13
55765636
[`needless_late_init`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
55775637
[`needless_lifetimes`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
55785638
[`needless_match`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_match
5639+
[`needless_maybe_sized`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized
55795640
[`needless_option_as_deref`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref
55805641
[`needless_option_take`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_take
55815642
[`needless_parens_on_range_literals`]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_parens_on_range_literals

‎Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "clippy"
3-
version = "0.1.80"
3+
version = "0.1.81"
44
description = "A bunch of helpful lints to avoid common pitfalls in Rust"
55
repository = "https://github.com/rust-lang/rust-clippy"
66
readme = "README.md"

‎README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ You can add options to your code to `allow`/`warn`/`deny` Clippy lints:
172172

173173
Note: `allow` means to suppress the lint for your code. With `warn` the lint
174174
will only emit a warning, while with `deny` the lint will emit an error, when
175-
triggering for your code. An error causes clippy to exit with an error code, so
175+
triggering for your code. An error causes Clippy to exit with an error code, so
176176
is useful in scripts like CI/CD.
177177

178178
If you do not want to include your lint levels in your code, you can globally
@@ -238,7 +238,7 @@ define the `CLIPPY_DISABLE_DOCS_LINKS` environment variable.
238238
### Specifying the minimum supported Rust version
239239

240240
Projects that intend to support old versions of Rust can disable lints pertaining to newer features by
241-
specifying the minimum supported Rust version (MSRV) in the clippy configuration file.
241+
specifying the minimum supported Rust version (MSRV) in the Clippy configuration file.
242242

243243
```toml
244244
msrv = "1.30.0"

‎book/src/configuration.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ For more details and options, refer to the Cargo documentation.
9999
### Specifying the minimum supported Rust version
100100

101101
Projects that intend to support old versions of Rust can disable lints pertaining to newer features by specifying the
102-
minimum supported Rust version (MSRV) in the clippy configuration file.
102+
minimum supported Rust version (MSRV) in the Clippy configuration file.
103103

104104
```toml
105105
msrv = "1.30.0"

‎book/src/development/basics.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ More about [intellij] command usage and reasons.
107107

108108
## lintcheck
109109

110-
`cargo lintcheck` will build and run clippy on a fixed set of crates and
110+
`cargo lintcheck` will build and run Clippy on a fixed set of crates and
111111
generate a log of the results. You can `git diff` the updated log against its
112112
previous version and see what impact your lint made on a small set of crates.
113113
If you add a new lint, please audit the resulting warnings and make sure there

‎book/src/development/defining_lints.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,11 @@ declare_clippy_lint! {
163163
///
164164
/// ### Example
165165
/// ```rust
166-
/// // example code where clippy issues a warning
166+
/// // example code where Clippy issues a warning
167167
/// ```
168168
/// Use instead:
169169
/// ```rust
170-
/// // example code which does not raise clippy warning
170+
/// // example code which does not raise Clippy warning
171171
/// ```
172172
#[clippy::version = "1.70.0"] // <- In which version was this implemented, keep it up to date!
173173
pub LINT_NAME, // <- The lint name IN_ALL_CAPS

‎book/src/development/proposals/syntax-tree-patterns.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ selection of possible matches is produced by the pattern syntax. In the second
428428
stage, the named subpattern references can be used to do additional tests like
429429
asserting that a node hasn't been created as part of a macro expansion.
430430

431-
## Implementing clippy lints using patterns
431+
## Implementing Clippy lints using patterns
432432

433433
As a "real-world" example, I re-implemented the `collapsible_if` lint using
434434
patterns. The code can be found
@@ -572,7 +572,7 @@ The pattern syntax and the *PatternTree* are independent of specific syntax tree
572572
implementations (rust ast / hir, syn, ...). When looking at the different
573573
pattern examples in the previous sections, it can be seen that the patterns
574574
don't contain any information specific to a certain syntax tree implementation.
575-
In contrast, clippy lints currently match against ast / hir syntax tree nodes
575+
In contrast, Clippy lints currently match against ast / hir syntax tree nodes
576576
and therefore directly depend on their implementation.
577577

578578
The connection between the *PatternTree* and specific syntax tree
@@ -690,7 +690,7 @@ change, only the `IsMatch` trait implementations need to be adapted and existing
690690
lints can remain unchanged. This also means that if the `IsMatch` trait
691691
implementations were integrated into the compiler, updating the `IsMatch`
692692
implementations would be required for the compiler to compile successfully. This
693-
could reduce the number of times clippy breaks because of changes in the
693+
could reduce the number of times Clippy breaks because of changes in the
694694
compiler. Another advantage of the pattern's independence is that converting an
695695
`EarlyLintPass` lint into a `LatePassLint` wouldn't require rewriting the whole
696696
pattern matching code. In fact, the pattern might work just fine without any
@@ -777,7 +777,7 @@ complexity to solve a relatively minor problem.
777777

778778
The issue of users not knowing about the *PatternTree* structure could be solved
779779
by a tool that, given a rust program, generates a pattern that matches only this
780-
program (similar to the clippy author lint).
780+
program (similar to the Clippy author lint).
781781

782782
For some simple cases (like the first example above), it might be possible to
783783
successfully mix Rust and pattern syntax. This space could be further explored
@@ -789,7 +789,7 @@ The pattern syntax is heavily inspired by regular expressions (repetitions,
789789
alternatives, sequences, ...).
790790

791791
From what I've seen until now, other linters also implement lints that directly
792-
work on syntax tree data structures, just like clippy does currently. I would
792+
work on syntax tree data structures, just like Clippy does currently. I would
793793
therefore consider the pattern syntax to be *new*, but please correct me if I'm
794794
wrong.
795795

@@ -982,5 +982,5 @@ pattern!{
982982
}
983983
```
984984

985-
In the future, clippy could use this system to also provide lints for custom
985+
In the future, Clippy could use this system to also provide lints for custom
986986
syntaxes like those found in macros.

‎clippy_config/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "clippy_config"
3-
version = "0.1.80"
3+
version = "0.1.81"
44
edition = "2021"
55

66
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

‎clippy_dummy/PUBLISH.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
This is a dummy crate to publish to crates.io. It primarily exists to ensure
2-
that folks trying to install clippy from crates.io get redirected to the
2+
that folks trying to install Clippy from crates.io get redirected to the
33
`rustup` technique.
44

55
Before publishing, be sure to rename `clippy_dummy` to `clippy` in `Cargo.toml`,

‎clippy_dummy/crates-readme.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
Installing clippy via crates.io is deprecated. Please use the following:
1+
Installing Clippy via crates.io is deprecated. Please use the following:
22

33
```terminal
44
rustup component add clippy
55
```
66

7-
on a Rust version 1.29 or later. You may need to run `rustup self update` if it complains about a missing clippy binary.
7+
on a Rust version 1.29 or later. You may need to run `rustup self update` if it complains about a missing Clippy binary.
88

99
See [the homepage](https://github.com/rust-lang/rust-clippy/#clippy) for more information

‎clippy_lints/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "clippy_lints"
3-
version = "0.1.80"
3+
version = "0.1.81"
44
description = "A bunch of helpful lints to avoid common pitfalls in Rust"
55
repository = "https://github.com/rust-lang/rust-clippy"
66
readme = "README.md"

‎clippy_lints/src/attrs/maybe_misused_cfg.rs

-51
This file was deleted.

‎clippy_lints/src/attrs/mismatched_target_os.rs

-90
This file was deleted.

0 commit comments

Comments
 (0)