Skip to content

Commit 33935cc

Browse files
borsbors
committed
Auto merge of #127820 - Oneirical:intestellar-travel, r=<try>
Rewrite and rename `issue-14698`. `issue-33329` and `issue-107094` `run-make` tests to rmake or ui Part of #121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: armhf-gnu try-job: test-various try-job: aarch64-apple try-job: x86_64-msvc
2 parents a28b35e + 6ef6243 commit 33935cc

File tree

10 files changed

+48
-20
lines changed

10 files changed

+48
-20
lines changed

‎src/tools/tidy/src/allowed_run_make_makefiles.txt

-3
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,11 @@ run-make/foreign-rust-exceptions/Makefile
4141
run-make/incr-add-rust-src-component/Makefile
4242
run-make/incr-foreign-head-span/Makefile
4343
run-make/interdependent-c-libraries/Makefile
44-
run-make/issue-107094/Makefile
45-
run-make/issue-14698/Makefile
4644
run-make/issue-15460/Makefile
4745
run-make/issue-22131/Makefile
4846
run-make/issue-25581/Makefile
4947
run-make/issue-26006/Makefile
5048
run-make/issue-28595/Makefile
51-
run-make/issue-33329/Makefile
5249
run-make/issue-35164/Makefile
5350
run-make/issue-36710/Makefile
5451
run-make/issue-47551/Makefile

‎tests/run-make/issue-14698/foo.rs ‎tests/run-make/invalid-tmpdir-env-var/foo.rs

File renamed without changes.

‎tests/run-make/invalid-tmpdir-env-var/rmake.rs

+18
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
// When the TMP or TMPDIR variable is set to an invalid or non-existing directory,
2+
// this used to cause an internal compiler error (ICE). After the addition of proper
3+
// error handling in #28430, this test checks that the expected message is printed.
4+
// See https://github.com/rust-lang/rust/issues/14698
5+
6+
use run_make_support::rustc;
7+
8+
// NOTE: This is not a UI test despite its simplicity, as the error message contains a path
9+
// with some variability that is difficult to normalize
10+
11+
fn main() {
12+
rustc()
13+
.input("foo.rs")
14+
.env("TMP", "fake")
15+
.env("TMPDIR", "fake")
16+
.run_fail()
17+
.assert_stderr_contains("couldn't create a temp dir");
18+
}

‎tests/run-make/issue-107094/Makefile

-7
This file was deleted.

‎tests/run-make/issue-14698/Makefile

-4
This file was deleted.

‎tests/run-make/issue-33329/Makefile

-5
This file was deleted.

‎tests/run-make/issue-33329/main.rs

-1
This file was deleted.

‎tests/run-make/version-verbose-commit-hash/rmake.rs

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
// `--version --verbose` should display the git-commit hashes of rustc and rustdoc, but this
2+
// functionality was lost due to #104184. After this feature was returned by #109981, this
3+
// test ensures it will not be broken again.
4+
// See https://github.com/rust-lang/rust/issues/107094
5+
6+
//@ needs-git-hash
7+
8+
use run_make_support::{bare_rustc, bare_rustdoc, regex};
9+
10+
fn main() {
11+
let out_rustc =
12+
bare_rustc().arg("--version").arg("--verbose").run().stdout_utf8().to_lowercase();
13+
let out_rustdoc =
14+
bare_rustdoc().arg("--version").arg("--verbose").run().stdout_utf8().to_lowercase();
15+
let re =
16+
regex::Regex::new(r#"commit-hash: [0-9a-f]{40}\ncommit-date: [0-9]{4}-[0-9]{2}-[0-9]{2}"#)
17+
.unwrap();
18+
assert!(re.is_match(&out_rustc));
19+
assert!(re.is_match(&out_rustdoc));
20+
}

‎tests/ui/errors/wrong-target-spec.rs

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
// The attentive may note the underscores in the target triple, making it invalid. This test
2+
// checks that such invalid target specs are rejected by the compiler.
3+
// See https://github.com/rust-lang/rust/issues/33329
4+
5+
//@ needs-llvm-components: x86
6+
//@ compile-flags: --target x86_64_unknown-linux-musl
7+
8+
fn main() {}

‎tests/ui/errors/wrong-target-spec.stderr

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
error: Error loading target specification: Could not find specification for target "x86_64_unknown-linux-musl". Run `rustc --print target-list` for a list of built-in targets
2+

0 commit comments

Comments
 (0)