Extra panic cases.

nnethercote · nnethercote · commit 2e4d547d4a86 · 2024-06-25T14:29:25.000+10:00
Just some extra sanity checking, making explicit some values not
possible in code working with token trees -- we shouldn't be seeing
explicit delimiter tokens, because they should be represented as
`TokenTree::Delimited`.
diff --git a/compiler/rustc_ast/src/attr/mod.rs b/compiler/rustc_ast/src/attr/mod.rs
@@ -327,7 +327,8 @@ impl MetaItem {
         I: Iterator<Item = &'a TokenTree>,
     {
         // FIXME: Share code with `parse_path`.
-        let path = match tokens.next().map(|tt| TokenTree::uninterpolate(tt)).as_deref() {
+        let tt = tokens.next().map(|tt| TokenTree::uninterpolate(tt));
+        let path = match tt.as_deref() {
             Some(&TokenTree::Token(
                 Token { kind: ref kind @ (token::Ident(..) | token::PathSep), span },
                 _,
@@ -368,6 +369,12 @@ impl MetaItem {
                 token::Nonterminal::NtPath(path) => (**path).clone(),
                 _ => return None,
             },
+            Some(TokenTree::Token(
+                Token { kind: token::OpenDelim(_) | token::CloseDelim(_), .. },
+                _,
+            )) => {
+                panic!("Should be `AttrTokenTree::Delimited`, not delim tokens: {:?}", tt);
+            }
             _ => return None,
         };
         let list_closing_paren_pos = tokens.peek().map(|tt| tt.span().hi());
diff --git a/compiler/rustc_expand/src/config.rs b/compiler/rustc_expand/src/config.rs
@@ -214,6 +214,12 @@ impl<'a> StripUnconfigured<'a> {
                 ) => {
                     panic!("Nonterminal should have been flattened: {:?}", tree);
                 }
+                AttrTokenTree::Token(
+                    Token { kind: TokenKind::OpenDelim(_) | TokenKind::CloseDelim(_), .. },
+                    _,
+                ) => {
+                    panic!("Should be `AttrTokenTree::Delimited`, not delim tokens: {:?}", tree);
+                }
                 AttrTokenTree::Token(token, spacing) => {
                     Some(AttrTokenTree::Token(token, spacing)).into_iter()
                 }

Original file line number	Diff line number	Diff line change
`@@ -214,6 +214,12 @@ impl<'a> StripUnconfigured<'a> {`
`214`	`214`	`) => {`
`215`	`215`	`panic!("Nonterminal should have been flattened: {:?}", tree);`
`216`	`216`	`}`
	`217`	`+ AttrTokenTree::Token(`
	`218`	`+ Token { kind: TokenKind::OpenDelim(_) \| TokenKind::CloseDelim(_), .. },`
	`219`	`+ _,`
	`220`	`+ ) => {`
	`221`	+ panic!("Should be `AttrTokenTree::Delimited`, not delim tokens: {:?}", tree);
	`222`	`+ }`
`217`	`223`	`AttrTokenTree::Token(token, spacing) => {`
`218`	`224`	`Some(AttrTokenTree::Token(token, spacing)).into_iter()`
`219`	`225`	`}`