Skip to content

Commit 23c8dec

Browse files
committed
Auto merge of #120593 - maurer:android-bump, r=Mark-Simulacrum
Update Android in CI We are currently using a 10+ year old Android image, and it has caused trouble when working on #120326. Our current NDK (25) only supports API 19+, so we were already out of spec. This PR: 1. Bumps the API used by the emulator in CI to 21, as per [NDK-26's release notes](https://github.com/android/ndk/wiki/Changelog-r26) deprecating 19 and 20 as targets. 2. Activates aarch64 testing on the emulator, since the base image is now a 64-bit image. 3. Bumps the NDK to 26b
2 parents 548e14b + 7c39eee commit 23c8dec

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ jobs:
204204
- self-hosted
205205
- ARM64
206206
- linux
207-
- name: arm-android
207+
- name: aarch64-android
208208
os: ubuntu-20.04-8core-32gb
209209
env: {}
210210
- name: armhf-gnu

src/ci/docker/host-x86_64/arm-android/Dockerfile src/ci/docker/host-x86_64/aarch64-android/Dockerfile

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ RUN sh /scripts/android-base-apt-get.sh
66

77
COPY scripts/android-ndk.sh /scripts/
88
RUN . /scripts/android-ndk.sh && \
9-
download_ndk android-ndk-r25b-linux.zip
9+
download_ndk android-ndk-r26b-linux.zip
1010

1111
RUN dpkg --add-architecture i386 && \
1212
apt-get update && \
@@ -21,14 +21,14 @@ RUN dpkg --add-architecture i386 && \
2121

2222
COPY scripts/android-sdk.sh /scripts/
2323
COPY scripts/android-sdk-manager.py /scripts/
24-
COPY host-x86_64/arm-android/android-sdk.lock /android/sdk/android-sdk.lock
24+
COPY host-x86_64/aarch64-android/android-sdk.lock /android/sdk/android-sdk.lock
2525
RUN /scripts/android-sdk.sh
2626

2727
ENV PATH=$PATH:/android/sdk/emulator
2828
ENV PATH=$PATH:/android/sdk/tools
2929
ENV PATH=$PATH:/android/sdk/platform-tools
3030

31-
ENV TARGETS=arm-linux-androideabi
31+
ENV TARGETS=arm-linux-androideabi,aarch64-linux-android
3232

3333
ENV RUST_CONFIGURE_ARGS --android-ndk=/android/ndk/
3434

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
emulator emulator-linux_x64-11237101.zip 0fd36dd5a7be6ee8770776a95c2933541d9243f3
2+
patcher;v4 3534162-studio.sdk-patcher.zip 046699c5e2716ae11d77e0bad814f7f33fab261e
3+
platform-tools platform-tools_r34.0.5-linux.zip 96097475cf7b279fdd8f218f5d043ffe94104ec3
4+
platforms;android-21 android-21_r02.zip 53536556059bb29ae82f414fd2e14bc335a4eb4c
5+
system-images;android-21;default;arm64-v8a sys-img/android/arm64-v8a-21_r04.zip c4375f1b4b4cd21a8617660e25f621cedcbd8332
6+
tools sdk-tools-linux-4333796.zip 8c7c28554a32318461802c1291d76fccfafde054

src/ci/docker/host-x86_64/arm-android/android-sdk.lock

-6
This file was deleted.

src/ci/docker/host-x86_64/dist-android/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ RUN sh /scripts/android-base-apt-get.sh
66
# ndk
77
COPY scripts/android-ndk.sh /scripts/
88
RUN . /scripts/android-ndk.sh && \
9-
download_ndk android-ndk-r25b-linux.zip
9+
download_ndk android-ndk-r26b-linux.zip
1010

1111
# env
1212
ENV TARGETS=arm-linux-androideabi

src/ci/github-actions/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ jobs:
381381
- name: aarch64-gnu
382382
<<: *job-aarch64-linux
383383

384-
- name: arm-android
384+
- name: aarch64-android
385385
<<: *job-linux-8c
386386

387387
- name: armhf-gnu

0 commit comments

Comments
 (0)