EXPERIMENT: Cache check_mod_type_wf and check_well_formed to see if that resolves most of the performance regression

oli-obk · oli-obk · commit 0da81044c7a0 · 2023-10-18T09:38:13.000Z
diff --git a/compiler/rustc_middle/src/query/mod.rs b/compiler/rustc_middle/src/query/mod.rs
@@ -977,6 +977,7 @@ rustc_queries! {
 
     query check_mod_type_wf(key: LocalModDefId) -> Result<(), ErrorGuaranteed> {
         desc { |tcx| "checking that types are well-formed in {}", describe_as_module(key, tcx) }
+        cache_on_disk_if { true }
     }
 
     query collect_mod_item_types(key: LocalModDefId) -> () {
@@ -1511,6 +1512,7 @@ rustc_queries! {
 
     query check_well_formed(key: hir::OwnerId) -> Result<(), ErrorGuaranteed> {
         desc { |tcx| "checking that `{}` is well-formed", tcx.def_path_str(key) }
+        cache_on_disk_if { true }
     }
 
     // The `DefId`s of all non-generic functions and statics in the given crate

Original file line number	Diff line number	Diff line change
`@@ -977,6 +977,7 @@ rustc_queries! {`
`977`	`977`
`978`	`978`	`query check_mod_type_wf(key: LocalModDefId) -> Result<(), ErrorGuaranteed> {`
`979`	`979`	`desc { \|tcx\| "checking that types are well-formed in {}", describe_as_module(key, tcx) }`
	`980`	`+ cache_on_disk_if { true }`
`980`	`981`	`}`
`981`	`982`
`982`	`983`	`query collect_mod_item_types(key: LocalModDefId) -> () {`
`@@ -1511,6 +1512,7 @@ rustc_queries! {`
`1511`	`1512`
`1512`	`1513`	`query check_well_formed(key: hir::OwnerId) -> Result<(), ErrorGuaranteed> {`
`1513`	`1514`	desc { \|tcx\| "checking that `{}` is well-formed", tcx.def_path_str(key) }
	`1515`	`+ cache_on_disk_if { true }`
`1514`	`1516`	`}`
`1515`	`1517`
`1516`	`1518`	// The `DefId`s of all non-generic functions and statics in the given crate