We don't look into static items anymore during const prop

oli-obk · oli-obk · commit 0b6cf3b78c96 · 2024-01-23T16:34:43.000Z
diff --git a/tests/ui/modulo_one.rs b/tests/ui/modulo_one.rs
@@ -33,7 +33,6 @@ fn main() {
     INT_MIN % NEG_ONE;
     //~^ ERROR: this operation will panic at runtime
     //~| ERROR: any number modulo -1 will panic/overflow or result in 0
-    // ONLY caught by rustc
+    // Not caught by lint, we don't look into static items, even if entirely immutable.
     INT_MIN % STATIC_NEG_ONE;
-    //~^ ERROR: this operation will panic at runtime
 }
diff --git a/tests/ui/modulo_one.stderr b/tests/ui/modulo_one.stderr
@@ -12,12 +12,6 @@ error: this operation will panic at runtime
 LL |     INT_MIN % NEG_ONE;
    |     ^^^^^^^^^^^^^^^^^ attempt to compute `i64::MIN % -1_i64`, which would overflow
 
-error: this operation will panic at runtime
-  --> $DIR/modulo_one.rs:37:5
-   |
-LL |     INT_MIN % STATIC_NEG_ONE;
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^ attempt to compute `i64::MIN % -1_i64`, which would overflow
-
 error: any number modulo 1 will be 0
   --> $DIR/modulo_one.rs:8:5
    |
@@ -57,5 +51,5 @@ error: any number modulo -1 will panic/overflow or result in 0
 LL |     INT_MIN % NEG_ONE;
    |     ^^^^^^^^^^^^^^^^^
 
-error: aborting due to 9 previous errors
+error: aborting due to 8 previous errors
 

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,6 @@ fn main() {`
`33`	`33`	`INT_MIN % NEG_ONE;`
`34`	`34`	`//~^ ERROR: this operation will panic at runtime`
`35`	`35`	`//~\| ERROR: any number modulo -1 will panic/overflow or result in 0`
`36`		`- // ONLY caught by rustc`
	`36`	`+ // Not caught by lint, we don't look into static items, even if entirely immutable.`
`37`	`37`	`INT_MIN % STATIC_NEG_ONE;`
`38`		`- //~^ ERROR: this operation will panic at runtime`
`39`	`38`	`}`