Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Conversation

@h-michael
Copy link
Contributor

@Xanewok
Copy link
Contributor

Xanewok commented Feb 3, 2019

Just in case - to fix the Rust PR you’ll have to update both RLS and Clippy submodules there; thanks for the fix here, though!

@Xanewok
Copy link
Contributor

Xanewok commented Feb 3, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Feb 3, 2019

📌 Commit c800a27 has been approved by Xanewok

bors added a commit that referenced this pull request Feb 3, 2019
@bors
Copy link
Contributor

bors commented Feb 3, 2019

⌛ Testing commit c800a27 with merge 31a7e44...

@bors
Copy link
Contributor

bors commented Feb 3, 2019

💔 Test failed - checks-travis

@h-michael
Copy link
Contributor Author

Now, I'm trying build clippy with master rustc.

@h-michael
Copy link
Contributor Author

I can build clippy with master rustc.
So we may update rust clippy revision at first.

@h-michael
Copy link
Contributor Author

create PR. rust-lang/rust#58093

@h-michael
Copy link
Contributor Author

@Xanewok Coud you retry?

@Xanewok
Copy link
Contributor

Xanewok commented Feb 3, 2019

We check nightly Rust in the CI, which does nit yet contain breaking changes.

New nightly releases are around 00:00 UTC everyday, so in a couple of hours we should have a version we can check with; I’ll retry then.

@h-michael
Copy link
Contributor Author

We became to use latest nightly(2019-02-04) :)

@Xanewok
Copy link
Contributor

Xanewok commented Feb 4, 2019 via email

bors added a commit that referenced this pull request Feb 4, 2019
@bors
Copy link
Contributor

bors commented Feb 4, 2019

⌛ Testing commit c800a27 with merge 6b012f9...

@bors
Copy link
Contributor

bors commented Feb 4, 2019

☀️ Test successful - checks-travis
Approved by: Xanewok
Pushing 6b012f9 to master...

@bors bors merged commit c800a27 into rust-lang:master Feb 4, 2019
@h-michael h-michael deleted the clippy branch February 4, 2019 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants