Add integer literal's grammar #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brauliobz
force-pushed
the
grammar_integer_literals
branch
3 times, most recently
from
113f9ea to
3976878
Compare
brauliobz
force-pushed
the
grammar_integer_literals
branch
from
3976878 to
e560bb6
Compare
Havvy
suggested changes
Sep 22, 2017
Contributor
Havvy
left a comment
Havvy
left a comment
There was a problem hiding this comment.
LGTM other than the literals with underscores.
src/tokens.md
Outdated
| > HEX_LITERAL : | ||
| > `0x` (HEX_DIGIT|`_`)<sup>\*</sup> HEX_DIGIT (HEX_DIGIT|`_`)<sup>\*</sup> | ||
| > | ||
| > BIN_DIGIT : [`0`-`1` `_`] |
Contributor
There was a problem hiding this comment.
As you have the or underscore in BIN_LITERAL, there shouldn't be an underscore in BIN_DIGIT or the other digits.
Havvy
approved these changes
Sep 23, 2017
Contributor
|
💟 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #84