enforce noalias on custom allocator Box by default#5067
Merged
Conversation
Collaborator
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
Member
|
libs-api convention dictates we call this this will be very useful, ty! |
RalfJung
force-pushed
the
noalias-custom-allocator-box
branch
from
May 27, 2026 06:11
a78faf9 to
34e5379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @nia-e, let's use the more conservative semantics for now. Also add a flag to disable noalias on custom allocator Boxes. That flag wins the price for the longest flag:
-Zmiri-tree-borrows-relax-custom-allocator-uniqueness. I am open to suggestions for shorter names. :)In Stacked Borrows we just always enforce full uniqueness. It's meant to be the strict model anyway.