-
Notifications
You must be signed in to change notification settings - Fork 471
Remove our RDTSC code? #4563
Copy link
Copy link
Closed
Labels
A-devArea: working on Miri as a developerArea: working on Miri as a developerC-proposalCategory: a proposal for something we might want to do, or maybe not; details still being worked outCategory: a proposal for something we might want to do, or maybe not; details still being worked out
Description
Metadata
Metadata
Assignees
Labels
A-devArea: working on Miri as a developerArea: working on Miri as a developerC-proposalCategory: a proposal for something we might want to do, or maybe not; details still being worked outCategory: a proposal for something we might want to do, or maybe not; details still being worked out
Type
Fields
Give feedbackNo fields configured for issues without a type.
In #4524 we gained some code to directly access the x86 RDTSC clock for profiling purposes. However, on almost all systems,
std::time::Instantshould already be using that clock. So maybe instead of carrying such low-level code we should document how to diagnose and potentially work-around the case where the kernel doesn't trust the RDTSC clock? If the clock is so unstable that the kernel doesn't use it, maybe it's also not a great fit for profiling...See the discussion here.
Cc @Stypox