avoid using macro_use

RalfJung · RalfJung · commit 321a3f075274 · 2024-05-26T22:56:07.000+02:00
diff --git a/cargo-miri/src/main.rs b/cargo-miri/src/main.rs
@@ -1,15 +1,14 @@
 #![allow(clippy::useless_format, clippy::derive_partial_eq_without_eq, rustc::internal)]
 
-#[macro_use]
-mod util;
-
 mod arg;
 mod phases;
 mod setup;
+mod util;
 
 use std::{env, iter};
 
 use crate::phases::*;
+use crate::util::show_error;
 
 /// Returns `true` if our flags look like they may be for rustdoc, i.e., this is cargo calling us to
 /// be rustdoc. It's hard to be sure as cargo does not have a RUSTDOC_WRAPPER or an env var that
diff --git a/cargo-miri/src/util.rs b/cargo-miri/src/util.rs
@@ -11,14 +11,15 @@ use serde::{Deserialize, Serialize};
 
 pub use crate::arg::*;
 
-pub fn show_error(msg: &impl std::fmt::Display) -> ! {
+pub fn show_error_(msg: &impl std::fmt::Display) -> ! {
     eprintln!("fatal error: {msg}");
     std::process::exit(1)
 }
 
 macro_rules! show_error {
-    ($($tt:tt)*) => { crate::util::show_error(&format_args!($($tt)*)) };
+    ($($tt:tt)*) => { crate::util::show_error_(&format_args!($($tt)*)) };
 }
+pub(crate) use show_error;
 
 /// The information to run a crate with the given environment.
 #[derive(Clone, Serialize, Deserialize)]
diff --git a/src/bin/miri.rs b/src/bin/miri.rs
@@ -8,7 +8,6 @@
 )]
 
 // Some "regular" crates we want to share with rustc
-#[macro_use]
 extern crate tracing;
 
 // The rustc crates we need
@@ -26,6 +25,8 @@ use std::num::NonZero;
 use std::path::PathBuf;
 use std::str::FromStr;
 
+use tracing::debug;
+
 use rustc_data_structures::sync::Lrc;
 use rustc_driver::Compilation;
 use rustc_hir::{self as hir, Node};
diff --git a/src/borrow_tracker/stacked_borrows/stack.rs b/src/borrow_tracker/stacked_borrows/stack.rs
@@ -2,6 +2,7 @@
 use std::ops::Range;
 
 use rustc_data_structures::fx::FxHashSet;
+use tracing::trace;
 
 use crate::borrow_tracker::{
     stacked_borrows::{Item, Permission},
diff --git a/src/concurrency/init_once.rs b/src/concurrency/init_once.rs
@@ -7,7 +7,7 @@ use super::sync::EvalContextExtPriv as _;
 use super::vector_clock::VClock;
 use crate::*;
 
-declare_id!(InitOnceId);
+super::sync::declare_id!(InitOnceId);
 
 #[derive(Default, Debug, Copy, Clone, PartialEq, Eq)]
 /// The current status of a one time initialization.
diff --git a/src/concurrency/mod.rs b/src/concurrency/mod.rs
@@ -1,8 +1,7 @@
 pub mod data_race;
+pub mod init_once;
 mod range_object_map;
-#[macro_use]
 pub mod sync;
-pub mod init_once;
 pub mod thread;
 mod vector_clock;
 pub mod weak_memory;
diff --git a/src/concurrency/sync.rs b/src/concurrency/sync.rs
@@ -61,6 +61,7 @@ macro_rules! declare_id {
         }
     };
 }
+pub(super) use declare_id;
 
 declare_id!(MutexId);
 
diff --git a/src/lib.rs b/src/lib.rs
@@ -53,7 +53,6 @@
 
 // Some "regular" crates we want to share with rustc
 extern crate either;
-#[macro_use]
 extern crate tracing;
 
 // The rustc crates we need
@@ -64,7 +63,6 @@ extern crate rustc_data_structures;
 extern crate rustc_errors;
 extern crate rustc_hir;
 extern crate rustc_index;
-#[macro_use]
 extern crate rustc_middle;
 extern crate rustc_session;
 extern crate rustc_span;
@@ -91,6 +89,8 @@ mod range_map;
 mod shims;
 
 // Establish a "crate-wide prelude": we often import `crate::*`.
+use rustc_middle::{bug, span_bug};
+use tracing::{info, trace};
 
 // Make all those symbols available in the same place as our own.
 #[doc(no_inline)]

Original file line number	Diff line number	Diff line change
`@@ -11,14 +11,15 @@ use serde::{Deserialize, Serialize};`
`11`	`11`
`12`	`12`	`pub use crate::arg::*;`
`13`	`13`
`14`		`-pub fn show_error(msg: &impl std::fmt::Display) -> ! {`
	`14`	`+pub fn show_error_(msg: &impl std::fmt::Display) -> ! {`
`15`	`15`	`eprintln!("fatal error: {msg}");`
`16`	`16`	`std::process::exit(1)`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`macro_rules! show_error {`
`20`		`- ($($tt:tt)) => { crate::util::show_error(&format_args!($($tt))) };`
	`20`	`+ ($($tt:tt)) => { crate::util::show_error_(&format_args!($($tt))) };`
`21`	`21`	`}`
	`22`	`+pub(crate) use show_error;`
`22`	`23`
`23`	`24`	`/// The information to run a crate with the given environment.`
`24`	`25`	`#[derive(Clone, Serialize, Deserialize)]`
Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@ macro_rules! declare_id {`
`61`	`61`	`}`
`62`	`62`	`};`
`63`	`63`	`}`
	`64`	`+pub(super) use declare_id;`
`64`	`65`
`65`	`66`	`declare_id!(MutexId);`
`66`	`67`