Solarish: add the arc4random* API family#3944
Conversation
|
@rustbot label stable-nominated |
|
This would help remove a FIXME in Relevant platform docs: |
|
Thanks for linking the docs. LGTM but I'll wait for one of the solarish people to double check this, or merge it in another day or two if we don't hear back. |
|
@devnexen maybe you can add the docs link to the PR description, so they become part of the commit message. (As I already told you in multiple past PRs, please write descriptions for your PRs! It makes them much easier to review, and therefore much more likely to be landed. It is not a great practice to throw a piece of code over the fence without saying a single sentence about the what and why and how.) |
70a5bb8 to
84cb528
Compare
84cb528 to
71f74cd
Compare
|
This looks fine to me so I will merge it, but wait for a solarish set of eyes before backport (@jclulow) |
[solaris](https://docs.oracle.com/cd/E88353_01/html/E37843/arc4random-buf-3c.html) [illumos](https://illumos.org/man/3C/arc4random_buf) (backport <rust-lang#3944>) (cherry picked from commit 71f74cd)
[solaris](https://docs.oracle.com/cd/E88353_01/html/E37843/arc4random-buf-3c.html) [illumos](https://illumos.org/man/3C/arc4random_buf) (backport <rust-lang#3944>) (cherry picked from commit 71f74cd)
[solaris](https://docs.oracle.com/cd/E88353_01/html/E37843/arc4random-buf-3c.html) [illumos](https://illumos.org/man/3C/arc4random_buf) (backport <rust-lang#3944>) (cherry picked from commit 71f74cd)
std: use `arc4random_buf` from libc Since I added these uses in rust-lang#129201 an `arc4random_buf` definition was added to libc for [Haiku](rust-lang/libc#3945) and [Solaris/Illumos](rust-lang/libc#3944) so we can stop redefining the symbol in `std`.
Rollup merge of #159597 - joboet:arc4random_libc, r=Darksonn std: use `arc4random_buf` from libc Since I added these uses in #129201 an `arc4random_buf` definition was added to libc for [Haiku](rust-lang/libc#3945) and [Solaris/Illumos](rust-lang/libc#3944) so we can stop redefining the symbol in `std`.
solaris
illumos