Skip to content

Conversation

@niluxv
Copy link
Contributor

@niluxv niluxv commented Nov 4, 2021

The constants to be passed in the data argument of procctl on freebsd.

Source for the constants: https://github.com/freebsd/freebsd-src/blob/main/sys/sys/procctl.h.

@rust-highfive
Copy link

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

@niluxv
Copy link
Contributor Author

niluxv commented Nov 4, 2021

Hm, seems that the ASLR and PROTMAX constants weren't there in FreeBSD 11 (and the PROTMAX ones also not in 12). But then PROC_ASLR_CTL, PROC_ASLR_STATUS, PROC_PROTMAX_CTL and PROC_PROTMAX_STATUS also weren't there in 11, so why do they not error?

@devnexen
Copy link
Contributor

devnexen commented Nov 4, 2021

little hint if that helps

"PROC_ASLR_CTL" | "PROC_ASLR_STATUS" | "PROC_PROCCTL_MD_MIN"

@niluxv
Copy link
Contributor Author

niluxv commented Nov 4, 2021

So IIUC the policy for constants is to just ignore them in tests for older FreeBSD versions (i.e. not defining the constants only for the appropriate versions of FreeBSD (freebsd12 and freebsd13 dirs), but keeping them globally in freebsd/mod.rs)?
Did that in the last commit.

@devnexen
Copy link
Contributor

devnexen commented Nov 4, 2021

freebsd1*/mod.rs are more likely, for example, for constants which had been updated b/w releases.

@niluxv
Copy link
Contributor Author

niluxv commented Nov 4, 2021

Ok. Thank you!

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Nov 5, 2021

📌 Commit e4bc201 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Nov 5, 2021

⌛ Testing commit e4bc201 with merge 4634afd...

@bors
Copy link
Contributor

bors commented Nov 5, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 4634afd to master...

@bors bors merged commit 4634afd into rust-lang:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants