Skip to content

Conversation

@LinkTed
Copy link
Contributor

@LinkTed LinkTed commented Sep 11, 2020

I added more constants for Linux like OS. Most of the new constants are IP_ and IPV6_ related.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@LinkTed LinkTed marked this pull request as draft September 22, 2020 20:00
@LinkTed
Copy link
Contributor Author

LinkTed commented Sep 22, 2020

I have to check if these constants exist in Linux musl.

@joshtriplett
Copy link
Member

@LinkTed CI seems happy with it, which means any constants that this PR adds to musl targets are also available to C on musl in a matching way.

Do you have a specific concern that CI wouldn't have caught here?

@LinkTed
Copy link
Contributor Author

LinkTed commented Oct 1, 2020

Oh, I did not know that. Okay if the Linux musl is also tested then it should be fine.

@LinkTed LinkTed marked this pull request as ready for review October 1, 2020 18:21
@joshtriplett joshtriplett merged commit 2ae4135 into rust-lang:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants