Auto merge of #3127 - JohnTitor:rm-semver-check, r=JohnTitor

bors · bors · commit eb5563f22f71 · 2023-02-22T10:30:30.000Z
Drop semver check job on CI

This hasn't run for a while and the crate no longer works unless a whole rewriting happens (due to the save analysis removal).
We sometimes allow breaking changes if an item doesn't work in all the use cases (i.e. we can imply there's no real user). For these reasons, I think it's fine to remove these jobs.
diff --git a/.github/workflows/bors.yml b/.github/workflows/bors.yml
@@ -317,32 +317,6 @@ jobs:
         run: LIBC_CI=1 TOOLCHAIN=${{ matrix.toolchain }} WIN_TARGET=${{ matrix.target }} sh ./ci/build.sh
         shell: bash
 
-  semver_linux:
-    if: ${{ false }} # This is currently broken
-    name: Semver Linux
-    runs-on: ubuntu-22.04
-    continue-on-error: true
-    steps:
-      - uses: actions/checkout@v3
-      - name: Setup Rust toolchain
-        # Should update the semverver revision in semver.sh if we touch nightly ver.
-        run: TOOLCHAIN=nightly-2022-05-23 sh ./ci/install-rust.sh
-      - name: Check breaking changes
-        run: sh ci/semver.sh linux
-
-  semver_macos:
-    if: ${{ false }} # This is currently broken
-    name: Semver macOS
-    runs-on: macos-12
-    continue-on-error: true
-    steps:
-      - uses: actions/checkout@v3
-      - name: Setup Rust toolchain
-        # Pin nightly version to make semverver compilable.
-        run: TOOLCHAIN=nightly-2022-05-23 sh ./ci/install-rust.sh
-      - name: Check breaking changes
-        run: sh ci/semver.sh macos
-
   docs:
     permissions:
       actions: write # to cancel workflows (rust-lang/simpleinfra/github-actions/cancel-outdated-builds)
diff --git a/ci/semver.sh b/ci/semver.sh
diff --git a/libc-test/semver/linux-gnu.txt b/libc-test/semver/linux-gnu.txt
@@ -669,4 +669,4 @@ strftime
 strptime
 dirname
 posix_basename
-gnu_basename
+gnu_basename
