Skip to content

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented May 2, 2019

Currently we are in a situation where Miri can be installed but cargo miri setup fails (due to rust-lang/miri#713). That should not lead to hashbrown's CI failing.

Cc @gnzlbg

@gnzlbg
Copy link
Contributor

gnzlbg commented May 2, 2019

This LGTM.

@Amanieu
Copy link
Member

Amanieu commented May 2, 2019

bors r+

@tesuji
Copy link
Contributor

tesuji commented May 6, 2019

@bors r=Amanieu

@bors
Copy link
Contributor

bors commented May 6, 2019

@lzutao: 🔑 Insufficient privileges: Not in reviewers

@Amanieu
Copy link
Member

Amanieu commented May 6, 2019

@bors r+

@bors
Copy link
Contributor

bors commented May 6, 2019

📌 Commit 419f2ac has been approved by Amanieu

@bors
Copy link
Contributor

bors commented May 6, 2019

⌛ Testing commit 419f2ac with merge 4368aa4...

bors added a commit that referenced this pull request May 6, 2019
skip Miri tests if the setup fails

Currently we are in a situation where Miri can be installed but `cargo miri setup` fails (due to rust-lang/miri#713).  That should not lead to hashbrown's CI failing.

Cc @gnzlbg
@bors
Copy link
Contributor

bors commented May 6, 2019

☀️ Test successful - checks-travis
Approved by: Amanieu
Pushing 4368aa4 to master...

@bors bors merged commit 419f2ac into rust-lang:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants