Skip to content

Add a backlink to newest for yanked crate versions #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2016

Conversation

tari
Copy link
Contributor

@tari tari commented Mar 26, 2016

Fixes #148.

Both paragraphs need to be wrapped in another div under crate-info since the stylesheet for crate-info makes a column-based layout which is not desirable for this case.

@alexcrichton
Copy link
Member

Perhaps this could be conditional to ensure that you don't back-link to the same page? (In the case that the newest version is yanked as well)

Also fix a bug in the versions template causing the yanked indicator to
never appear.
@tari
Copy link
Contributor Author

tari commented Mar 28, 2016

I changed it to link to all versions, which is still friendly for the case that the newest version has been yanked. Also fixed a bug from 73c2e12 where the crate versions list would never indicate a version had been yanked.

@alexcrichton
Copy link
Member

Thanks!

@alexcrichton alexcrichton merged commit 7903e75 into rust-lang:master Mar 28, 2016
bors added a commit that referenced this pull request Dec 18, 2019
…8.0.0, r=Turbo87

Bump ember-moment from 7.5.0 to 8.0.0

Bumps [ember-moment](https://github.com/stefanpenner/ember-moment) from 7.5.0 to 8.0.0.
<details>
<summary>Release notes</summary>

*Sourced from [ember-moment's releases](https://github.com/stefanpenner/ember-moment/releases).*

> ## Add smoke tests, travis ci now tests against 1.10->#release, fixes regression against Ember 1.10.0
> - Smoke tests added
> - Fixing regression which broke 1.10.0
> - Added Ember 1.10.0 -> #release to the Travis CI matrix
</details>
<details>
<summary>Changelog</summary>

*Sourced from [ember-moment's changelog](https://github.com/stefanpenner/ember-moment/blob/master/CHANGELOG.md).*

> ### 8.0.0
>
> * [BREAKING] drops Node 6 support
> * Updates ember-macro-helpers to 4.x
>
> ### 7.8.1
>
> * [@&#8203;puwelous](https://github.com/puwelous) Substitute merge() with assign() - Ember deprecation [#296](https://github-redirect.dependabot.com/stefanpenner/ember-moment/issues/296)
> * [@&#8203;jasonmit](https://github.com/jasonmit) ci: Bump Supported Node version from 4 to 6.
> * [@&#8203;kellyselden](https://github.com/kellyselden) update ember-macro-helpers [#285](https://github-redirect.dependabot.com/stefanpenner/ember-moment/issues/285)
> * [@&#8203;scottkidder](https://github.com/scottkidder) Replace Logger with console [#281](https://github-redirect.dependabot.com/stefanpenner/ember-moment/issues/281)
>
> ### 7.7.0
>
> * [@&#8203;fenekku](https://github.com/fenekku) deprecated hideSuffix/hidePrefix in favor of hideAffix
> * [@&#8203;crotwell](https://github.com/crotwell) added utc helper & macro
> *
>
> ### 7.6.0
>
> * [@&#8203;kellyselden](https://github.com/kellyselden) Fix invalid reexport for helpers/unix
> * Upgrade ember-cli and dependencies
>
> ### 7.3.0
>
> * Setting locale now sets locale on global moment object
> * Added `setLocale` and `setTimeZone`.  Better naming.  Will continue to support `changeLocale` and `changeTimeZone` but have updated README to prefer new method names
> * Added `localeChanged` and `timeZoneChanged` events
> * [@&#8203;mfeltz](https://github.com/mfeltz) scoped moment-subtract and moment-add to use the moment service `locale` property
>
> ### 7.2.0
>
> * [@&#8203;kellyselden](https://github.com/kellyselden) add back `ember-macro-helpers`
>
> ### 7.1.1
>
> * Removed `ember-macro-helpers`
>
> ### 7.1.0
>
> * [@&#8203;kellyselden](https://github.com/kellyselden) ported computed macro factory to use computed macro utility methods from `ember-macro-helpers`
>
> ### 7.0.3
>
> * Upgrade `ember-cli-moment-shim` to 3.0.0
> * now helper now recomputes using setTimeout instead of run.later [#205](https://github-redirect.dependabot.com/stefanpenner/ember-moment/issues/205)
>
> ### 7.0.2
>
> * Revert upgrade `ember-cli-moment-shim` to 2.2.1 (moment.now issue)
></tr></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`7334cee`](adopted-ember-addons/ember-moment@7334cee) 8.0.0
- [`61aa2c1`](adopted-ember-addons/ember-moment@61aa2c1) chore: Update changelog.
- [`4b56658`](adopted-ember-addons/ember-moment@4b56658) Merge pull request [#314](https://github-redirect.dependabot.com/stefanpenner/ember-moment/issues/314) from GreatWizard/update-ember-macro-helpers
- [`bef3ffe`](adopted-ember-addons/ember-moment@bef3ffe) ci: update CI config and engines node to run on node 8 and upper
- [`9e1bdcd`](adopted-ember-addons/ember-moment@9e1bdcd) chore: update ember-macro-helpers version to expose a recent one in dependency
- [`f7eeb90`](adopted-ember-addons/ember-moment@f7eeb90) Merge pull request [#310](https://github-redirect.dependabot.com/stefanpenner/ember-moment/issues/310) from himynameisjonas/patch-1
- [`29e4029`](adopted-ember-addons/ember-moment@29e4029) Replace merge with assign
- [`a14c935`](adopted-ember-addons/ember-moment@a14c935) Merge pull request [#305](https://github-redirect.dependabot.com/stefanpenner/ember-moment/issues/305) from mbinet/cleanup-readme
- [`7469733`](adopted-ember-addons/ember-moment@7469733) Move contributing informations to dedicated file
- [`2dc62a8`](adopted-ember-addons/ember-moment@2dc62a8) Add TOC
- Additional commits viewable in [compare view](adopted-ember-addons/ember-moment@v7.5.0...v8.0.0)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-moment&package-manager=npm_and_yarn&previous-version=7.5.0&new-version=8.0.0)](https://dependabot.com/compatibility-score.html?dependency-name=ember-moment&package-manager=npm_and_yarn&previous-version=7.5.0&new-version=8.0.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants