Proposal

The rustc compiler crates contain a file containing all #[derive(Diagnostic)] structs. Whether this is good design is out of scope for this MCP.

We started renaming all files to diagnostics.rs, as they don't contain only structs for errors, but also structs for warnings and since recently lints. It was pointed out that this change should have been MCP'ed. This MCP proposes to finish renaming all files to diagnostics.rs.

For reference, there are currently:

• 22 crates that name this file diagnostics.rs (These were already renamed from one of the other variants)
• 6 crates that name this file errors.rs
• 4 crates that name this file error.rs
• 3 crates that name this file session_diagnostics.rs
• 2 crates that name this file lints.rs

Mentors or Reviewers

This is a change @GuillaumeGomez and I are proposing and will implement.

Process

The main points of the Major Change Process are as follows:

• File an issue describing the proposal.
• A compiler team member who is knowledgeable in the area can second by writing @rustbot second or kickoff a team FCP with @rfcbot fcp $RESOLUTION.
  • Refer to Proposals, Approvals and Stabilization docs for when a second is sufficient, or when a full team FCP is required.
• Once an MCP is seconded, the Final Comment Period begins.
  • Final Comment Period lasts for 10 days after all outstanding concerns are solved.
  • Outstanding concerns will block the Final Comment Period from finishing. Once all concerns are resolved, the 10 day countdown is restarted.
  • If no concerns are raised after 10 days since the resolution of the last outstanding concern, the MCP is considered approved.

You can read more about Major Change Proposals on forge.