Remove compiler-rt submodule from this repository
#294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
compiler-rtsubmodule from this repository.The goal here is to align the
compiler-rtused for compiling Cintrinsics with the upstream rust-lang/rust's usage of
llvm-project.Currently we have both an
llvm-projectrepository as well ascompiler-rt, but they can naturally get out of sync and it's just onemore submodule to manage.
The thinking here is that the feature
cfor this crate, whenactivated, will require the user to configure where the source code for
compiler-rtis present. This places the onus on the builder ofcompiler-builtinsto check-out and arrange for the appropriatecompiler-rtsource code to be placed somewhere. For rust-lang/rustthis is already done with the
llvm-projectsubmodule, and we canarrange for it to happen on this crate's CI anyway.
For users of this crate this is a bit of a bummer, but
cis disabledby default anyway and it seems unlikely that
cis explicitly opted into all that much. (given the purpose of this crate)
This should allow us to archive the
compiler-rtrepository and simplyuse
llvm-projectin the rust-lang/rust repository.