Skip to content

ci: Test on riscv64 using a self-hosted runner#1059

Merged
tgross35 merged 1 commit intorust-lang:mainfrom
yuzibo:add-self-hosted-on-riscv64
Mar 23, 2026
Merged

ci: Test on riscv64 using a self-hosted runner#1059
tgross35 merged 1 commit intorust-lang:mainfrom
yuzibo:add-self-hosted-on-riscv64

Conversation

@yuzibo
Copy link
Copy Markdown
Contributor

@yuzibo yuzibo commented Jan 9, 2026

Closes: #1054

ci: test-libm

@yuzibo yuzibo force-pushed the add-self-hosted-on-riscv64 branch from b174918 to 0e95c55 Compare January 9, 2026 12:35
@yuzibo
Copy link
Copy Markdown
Contributor Author

yuzibo commented Jan 9, 2026

To address the issue.

I left some comments on there, please review it also

Comment thread .github/workflows/main.yaml Outdated
Comment thread .github/workflows/main.yaml Outdated
Comment thread .github/workflows/main.yaml Outdated

- name: Download musl source
run: |
sed -i 's|https://github.com/kraj/musl.git|https://community-ci.openruyi.cn/others/kraj-musl.git|g' ./ci/update-musl.sh
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope these sed usages can be accepted in order to speed up the whole workflow. And this clearly demonstrates what we did.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the speed difference that significant? I'd rather not use the mirrors if possible to reduce the possible points of failure or things that could get out of sync.

Copy link
Copy Markdown
Contributor Author

@yuzibo yuzibo Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is one of the feasible solutions we can implement.

On the self-hosted riscv64 runners, outbound access to some upstream services can be intermittently unstable due to external network factors, which may occasionally affect CI reliability before the actual build or tests start from my experimental. In fact,localized mirror services were included as an initial goal of this project to ensure the stability of CI.

Regarding the risk of mirrors getting out of sync: these mirrors are actively maintained and have a daily synchronization mechanism to track upstream changes, along with basic health checks to ensure they remain usable. This helps reduce the risk of silent divergence.

We do not publish our mirror service in case other users abuse it to affect the stability of our CI, if necessary, we can publish it after our internal assessment.

Using these Prepare mirrored sources with sed is a more transparent approach than using a cached solution, which increases complexity. But for r-l/r, we have to depend on lots of cache strategy, If we get to that point.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with infra on Zulip (starting around here #t-infra > RISC-V runner in compiler builtins @ 💬) that we don't want to use these mirrors. It's fine to keep around while you're still testing, but please drop them at some point.

If there's some weird circumstances making these mirrors work better than GH, bring it up on Zulip so we can see if there's something we can do.

@yuzibo yuzibo force-pushed the add-self-hosted-on-riscv64 branch from 0e95c55 to b96d13f Compare January 11, 2026 14:56
@yuzibo yuzibo changed the title Draft to support CI job on riscv64 self hosted To support CI job on riscv64 self hosted Jan 11, 2026
@yuzibo yuzibo changed the title To support CI job on riscv64 self hosted To support CI job on riscv64 self hosted runner Jan 12, 2026
@yuzibo yuzibo force-pushed the add-self-hosted-on-riscv64 branch from b96d13f to 1a1d2f9 Compare March 15, 2026 14:57
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@yuzibo yuzibo force-pushed the add-self-hosted-on-riscv64 branch from 1a1d2f9 to 3d9410c Compare March 16, 2026 10:29
@rustbot

This comment has been minimized.

@yuzibo yuzibo force-pushed the add-self-hosted-on-riscv64 branch 2 times, most recently from c55151b to ec3f9cb Compare March 17, 2026 03:21
@rustbot

This comment has been minimized.

@yuzibo yuzibo force-pushed the add-self-hosted-on-riscv64 branch from ec3f9cb to efe7adb Compare March 17, 2026 16:18
@rustbot

This comment has been minimized.

@yuzibo yuzibo force-pushed the add-self-hosted-on-riscv64 branch from efe7adb to 91a47f1 Compare March 17, 2026 16:26
Comment thread .github/workflows/main.yaml Outdated
@yuzibo yuzibo force-pushed the add-self-hosted-on-riscv64 branch from 91a47f1 to 9f332b5 Compare March 17, 2026 16:34
@tgross35 tgross35 changed the title To support CI job on riscv64 self hosted runner ci: Test on riscv64 using a self-hosted runner Mar 17, 2026
Copy link
Copy Markdown
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just marking non-mergable for now due to mirrors)

View changes since this review

@yuzibo yuzibo force-pushed the add-self-hosted-on-riscv64 branch 2 times, most recently from 3b5a163 to b658e1a Compare March 18, 2026 14:29
@rustbot

This comment has been minimized.

@yuzibo
Copy link
Copy Markdown
Contributor Author

yuzibo commented Mar 18, 2026

We can add riscv64 runners first then merge this PR if no problem.

@yuzibo yuzibo force-pushed the add-self-hosted-on-riscv64 branch from b658e1a to 7bfad63 Compare March 23, 2026 10:20
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 23, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@yuzibo yuzibo force-pushed the add-self-hosted-on-riscv64 branch from 7bfad63 to fc7cd1d Compare March 23, 2026 10:41
@yuzibo yuzibo force-pushed the add-self-hosted-on-riscv64 branch from fc7cd1d to b7f5310 Compare March 23, 2026 12:16
@tgross35
Copy link
Copy Markdown
Contributor

Mind rebasing so we get a fresh run with the more recent CI changes?

Copy link
Copy Markdown
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we'll get a fresh run after merge anyway, let's get this in 🎉

View changes since this review

@tgross35 tgross35 merged commit 0a6178b into rust-lang:main Mar 23, 2026
43 checks passed
@yuzibo yuzibo deleted the add-self-hosted-on-riscv64 branch March 28, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: support ci job on riscv64 hardware

3 participants