fix(ar): deterministic archives with D modifier#1697
Merged
NobodyXu merged 2 commits intorust-lang:mainfrom Apr 2, 2026
Merged
fix(ar): deterministic archives with D modifier#1697NobodyXu merged 2 commits intorust-lang:mainfrom
D modifier#1697NobodyXu merged 2 commits intorust-lang:mainfrom
Conversation
NobodyXu
requested changes
Apr 1, 2026
| // Not all ar implementations support it, so we try with `D` first | ||
| // and fall back without it. | ||
| if !run_silent(cmd.arg("cqD").arg(dst).args(objs)) { | ||
| let (mut cmd, _, _) = self.try_get_archiver_and_flags()?; |
Contributor
There was a problem hiding this comment.
It seems that we already set this, just before the if?
Member
Author
There was a problem hiding this comment.
Command doesn't implemented Clone, unfortunately.
Contributor
There was a problem hiding this comment.
Thanks, in that case shall we remove that env setting, given that we use option D then?
Member
Author
There was a problem hiding this comment.
See the simplified version :)
The `cq` path already sets this for determinism on macOS, but the subsequent `ar s` step was missing it.
weihanglo
commented
Apr 2, 2026
| // Not all ar implementations support it, so we try with `D` first | ||
| // and fall back without it. | ||
| if !run_silent(cmd.arg("cqD").arg(dst).args(objs)) { | ||
| let (mut cmd, _, _) = self.try_get_archiver_and_flags()?; |
Member
Author
There was a problem hiding this comment.
Command doesn't implemented Clone, unfortunately.
NobodyXu
requested changes
Apr 2, 2026
Try the `D` modifier which zeros out timestamps in archive headers. Fall back to the previous behavior if not supported. See <rust-lang#1696>
|
Hi, I maintain the project https://github.com/Orange-OpenSource/hurl, I try to identify some new warnings on macOS / Sequoia: $ cargo build
...
warning: [email protected]: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ar: illegal option -- D
warning: [email protected]: usage: ar -d [-TLsv] archive file ...
warning: [email protected]: ar -m [-TLsv] archive file ...
warning: [email protected]: ar -m [-abiTLsv] position archive file ...
warning: [email protected]: ar -p [-TLsv] archive [file ...]
warning: [email protected]: ar -q [-cTLsv] archive file ...
warning: [email protected]: ar -r [-cuTLsv] archive file ...
warning: [email protected]: ar -r [-abciuTLsv] position archive file ...
warning: [email protected]: ar -t [-TLsv] archive [file ...]
warning: [email protected]: ar -x [-ouTLsv] archive [file ...]
Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.03sThis warning happens when I'm upgrading cc from 1.2.58 to 1.2.59: With 1.2.58: $ cargo build
Compiling cc v1.2.58
Compiling openssl-sys v0.9.112
Compiling libz-sys v1.1.25
Compiling curl-sys v0.4.87+curl-8.19.0
Compiling hurl v8.0.0-SNAPSHOT (/Users/jc/Documents/Dev/hurl/packages/hurl)
Compiling curl v0.4.49
Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.17sJust updating to 1.2.59: $ cargo build
Updating crates.io index
Locking 1 package to latest compatible version
Updating cc v1.2.58 -> v1.2.59
warning: [email protected]: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ar: illegal option -- D
warning: [email protected]: usage: ar -d [-TLsv] archive file ...
warning: [email protected]: ar -m [-TLsv] archive file ...
warning: [email protected]: ar -m [-abiTLsv] position archive file ...
warning: [email protected]: ar -p [-TLsv] archive [file ...]
warning: [email protected]: ar -q [-cTLsv] archive file ...
warning: [email protected]: ar -r [-cuTLsv] archive file ...
warning: [email protected]: ar -r [-abciuTLsv] position archive file ...
warning: [email protected]: ar -t [-TLsv] archive [file ...]
warning: [email protected]: ar -x [-ouTLsv] archive [file ...]
Compiling hurl v8.0.0-SNAPSHOT (/Users/jc/Documents/Dev/hurl/packages/hurl)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.73sI've this impression that this issue is related to this PR, but maybe I'm mistaken... |
jcamiel
added a commit
to Orange-OpenSource/hurl
that referenced
this pull request
Apr 5, 2026
Member
Author
|
Yes. That is from this PR. We might need to suppress the first probe invocation, if failed. |
Member
Author
|
The warning doesn't really matter on macOS for the default archiver though. No need to revert unless you feel annoyed by those should-be-silented warnings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try the
Dmodifier which zeros out timestamps in archive headers.Fall back to the previous behavior if not supported.
Fixes #1696