Size archiver batches according to argument length not argument count#1689
Merged
NobodyXu merged 1 commit intorust-lang:mainfrom Mar 13, 2026
Merged
Size archiver batches according to argument length not argument count#1689NobodyXu merged 1 commit intorust-lang:mainfrom
NobodyXu merged 1 commit intorust-lang:mainfrom
Conversation
Member
|
Long term I do think think it'd be better to use command files for tools that support it rather than batching arguments like this. But that's a bigger change. |
Contributor
Opened new issue #1690 |
NobodyXu
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am running into command line length overflow failures in
assemble_progressive's msvc codepath. The object file paths involved are relatively long: more than 70 characters on average. So the heuristic inccof passing batches of 100 objects to the archiver results in an excessively long command line.This PR switches to an approximate character-based limit for the batches.
In my use case a limit of up to 7200 worked. I have brought this down to 4000 for the PR to leave plenty of room for things like wrapper scripts that want to insert flags into the archiver command.