Conversation
This was referenced Feb 27, 2026
Such that it's also tracked by Cargo.
Into: - `cargo_env_var_os` - `Build::get_env` - `Build::get_env_overridable`
The following methods should also be affected by `Build::env`: - `Build::[try_]get_compiler` - `Build::[try_]get_archiver` - `Build::[try_]get_ranlib`
madsmtm
force-pushed
the
fix-env-stuff
branch
2 times, most recently
from
c22947c to
d9e4c8e
Compare
NobodyXu
requested changes
Mar 9, 2026
Co-authored-by: Jiahao XU <[email protected]>
NobodyXu
requested changes
Mar 10, 2026
Contributor
Author
|
Done now, I also opened #1688 to track further extensions to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1656.
This implements what I proposed in there, primarily:
Build::getenvinto several functions, depending on the use-case, see rename__set_envtoenvand make it un-hidden #1656 (comment) for discussion.Build::envpropagate to theTool/Commands returned byBuild::[try_]get_[compiler|archiver|ranlib].See each commit for details (I can split it up into several PRs if you prefer?)