Fix rustcflags mapping: require -Clinker-plugin-lto for -flto#1564
Merged
Fix rustcflags mapping: require -Clinker-plugin-lto for -flto#1564
Conversation
And ignore -Clto Fixed #1463
dot-asm
reviewed
Sep 23, 2025
dot-asm
reviewed
Sep 23, 2025
Contributor
|
While you're at it Line 516 in 9a2e7ce |
NobodyXu
changed the title
Contributor
Author
Thanks, fixed |
dot-asm
reviewed
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only when -Clto and -Clinker-plugin-lto are both specified, would we pass -flto, making sure that we won't break environments which has ar doesn't support llvm ir bitcode and linker that doesn't have llvm lto plugin.
Fixed #1463