Skip to content

Replace periods with underscores as well when parsing env variables#1541

Merged
NobodyXu merged 2 commits intorust-lang:mainfrom
datdenkikniet:support-periods
Sep 3, 2025
Merged

Replace periods with underscores as well when parsing env variables#1541
NobodyXu merged 2 commits intorust-lang:mainfrom
datdenkikniet:support-periods

Conversation

@datdenkikniet
Copy link
Copy Markdown
Contributor

Fixes #1540

Copy link
Copy Markdown
Contributor

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NobodyXu NobodyXu merged commit ee81cbf into rust-lang:main Sep 3, 2025
77 checks passed
@datdenkikniet
Copy link
Copy Markdown
Contributor Author

datdenkikniet commented Sep 3, 2025

As a question, if you happen to have an answer: is there any sort of release cadence/ETA for when we might expect a version of cc to be released with this change merged in? We're not in a horrible hurry to get this working, but putting an ETA on our "update cc to latest` work item would be neat :)

If not, we will be as patient as necessary. Thank you for your efforts in maintaining this crate!

ETA: whoops, just saw you have a bot that performs semi-automatic upgrades in #1542. So it looks like it will be Pretty Quick ™️ Very cool, we'll be patient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selecting compiler specifically for thumbv8m.main-none-eabi and other . containing targets does not work

2 participants