Conversation
| }; | ||
|
|
||
| let cl_exe = self.windows_registry_find_tool(&target, "cl.exe"); | ||
| let cl_exe = self.windows_registry_find_tool(&target, msvc); |
There was a problem hiding this comment.
cc @ChrisDenton I would need some help on how to find clang-cl, here I just pass clang-cl.exe to windows_registry::find_tool if user prefers clang-cl over msvc, hoping it would find it, not sure if it is correct.
There was a problem hiding this comment.
That might find it if it's installed with Visual Studio but it could be installed separately. We should more strongly prefer the environment for clang-cl (e.g. checking PATH as well).
There was a problem hiding this comment.
Should add I a dedicated PATH checking logic for clang-cl.exe?
Or should I add that to windows_registry::find_tool?
There was a problem hiding this comment.
I think adding dedicated PATH checking logic is the safest option.
It'd be nice if find_tool where consistent but it's possible people may use it to specifically find the VS installed version. So unless someone complains about the find_tool behaviour, I'm not sure if it's worth the (admittedly small) risk of breakage.
There was a problem hiding this comment.
That might find it if it's installed with Visual Studio but it could be installed separately. We should more strongly prefer the environment for clang-cl (e.g. checking PATH as well).
If it is installed separately then the user should specify CC/TARGET_CC when building. Otherwise, I think the behavior should be "use the clang-cl provided with the version of MSVC that we were about to use."
|
cc @madsmtm I am really busy recently and I don't think I can work on this for the next week, if you have time, can you take up this please? |
I'd rather not, I don't feel familiar enough with MSVC to feel confident in anything relating to that, sorry :/. |
|
cc @ChrisDenton hello, can you take over this PR please? I don't have time recently to continue push this. |
|
Sure, I've added it to my queue. |
|
Thank you |
|
Is this possibly missing |
|
(a) f the user has set (b) IDK what to do when the user set If the user set |
|
Closing in favor of #1516 |
5 participants
No description provided.