Fix for different hashes between different build paths#1277
Closed
harishsadineni1 wants to merge 1 commit intorust-lang:mainfrom
Closed
Fix for different hashes between different build paths#1277harishsadineni1 wants to merge 1 commit intorust-lang:mainfrom
harishsadineni1 wants to merge 1 commit intorust-lang:mainfrom
Conversation
when the build paths are diffrent for rust sources, the objects files genarted are having diffrent hash values for each build. - Updated the hashing mechanism to ensure consistent hash values across different build paths. - Addressed issues with reproducibility by normalizing directory paths before hashing, preventing discrepancies caused by varying build environments. Signed-off-by: Harish Sadineni <[email protected]>
NobodyXu
requested changes
Nov 7, 2024
| pos | ||
| } | ||
|
|
||
| let filtered_dirname = if let Some(pos) = find_target_position(&dirname, &target_substring) { |
Contributor
There was a problem hiding this comment.
IMHO stripping rustc isn't very reliable, user could have rustc somewhere in the path.
I think stripping CARGO_MANIFEST_DIR is a better solution.
Contributor
|
Thanks, I think #1270 already implements this |
joshtriplett
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the build paths are diffrent for rust sources, the objects files genarted are having diffrent hash values for each build.