-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fossil VCS support to cargo new
#4155
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Fossil is a simple, high-reliability, distributed software configuration management system <https://www.fossil-scm.org/>
There's a CI failure but it looks like it's happening in Windows stuff that I don't think I can have touched?
|
@bors: r+ Thanks! That error may bounce this PR but I'll take care of it, no worries! |
📌 Commit 7eca7f2 has been approved by |
⌛ Testing commit 7eca7f2 with merge 0279815... |
💔 Test failed - status-appveyor |
@bors retry Looks like the spurious failure noted above. |
@bors: retry |
⌛ Testing commit 7eca7f2 with merge faa7668... |
💔 Test failed - status-travis |
@bors: retry
…On Tue, Jun 13, 2017 at 9:41 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/cargo/builds/242578683?utm_source=github_status&utm_medium=notification>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4155 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95PxT4NhO7b_t7VEL6VNUbeLywbKrks5sD0hIgaJpZM4N19k9>
.
|
Add fossil VCS support to `cargo new` Fossil is a simple, high-reliability, distributed software configuration management system <https://www.fossil-scm.org/> I mostly followed #3842 as a template. Like that one, this only adds support for `cargo new`, not for pulling down fossil-hosted dependencies A problem that i didn't tackle but I'd be willing to is a little more more `trait`ifying of the VCSs. I would need some guidance on that since it looks like git has some more thorough support than e.g. hg does but it looks pretty doable
☀️ Test successful - status-appveyor, status-travis |
Awesome! Thanks all! |
Fossil is a simple, high-reliability, distributed software configuration management system https://www.fossil-scm.org/
I mostly followed #3842 as a template. Like that one, this only adds support for
cargo new
, not for pulling down fossil-hosted dependenciesA problem that i didn't tackle but I'd be willing to is a little more more
trait
ifying of the VCSs. I would need some guidance on that since it looks like git has some more thorough support than e.g. hg does but it looks pretty doable