Assert that we don't build test project twice. #3708
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r+ from me! I think there's a few nighty-only tests failing though? |
matklad
force-pushed
the
assert-tests
branch
from
0bef17b to
aab6a89
Compare
Hm, actually there's a whole bunch of tests failing, because I've forgotten that tests are fail-fast by default :) |
tests/path.rs
Outdated
|
|
||
| p.build(); // rebuild the files (rewriting them in the process) |
There was a problem hiding this comment.
@alexcrichton I don't understand how this test is supposed to work. We move files into the past and immediately replace them...
Also, the assertion on the previous line looks suspicions, because we never print to stdout in build....
There was a problem hiding this comment.
This test has not survived the test of time well.
Let's just delete this test from this clause down, but leave the above clauses. We should have tons of tests for rebuilding, so it's not critical that this exact tests works.
Also note that this test is in no way testing what its name implies as well :)
There was a problem hiding this comment.
Let's just delete this test from this clause down, but leave the above clauses. We should have tons of tests for rebuilding, so it's not critical that this exact tests works.
Hm, that test would test nothing at all then I think... I've brought it in line with its title :)
matklad
force-pushed
the
assert-tests
branch
2 times, most recently
from
7271c74 to
4556f30
Compare
That may work on linux and fail on windows, so it's better to proactively verify it.
matklad
force-pushed
the
assert-tests
branch
from
4556f30 to
5e8eef9
Compare
|
@bors: r+ Thanks! |
|
📌 Commit 73f870c has been approved by |
|
⌛ Testing commit 73f870c with merge cd8b72c... |
|
💔 Test failed - status-appveyor |
|
@bors: retry |
|
⌛ Testing commit 73f870c with merge cadc619... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network error
…On Thu, Feb 16, 2017 at 1:20 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/cargo/builds/202363776>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3708 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95BKL4VJIxIppRwiAbxToWy0ABdWzks5rdKFngaJpZM4MBxLF>
.
|
|
⌛ Testing commit 73f870c with merge f07314e... |
|
💔 Test failed - status-travis |
|
@bors: retry |
|
⌛ Testing commit 73f870c with merge 3fd66f8... |
|
💔 Test failed - status-travis |
|
@bors: retry
…On Thu, Feb 16, 2017 at 4:04 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/cargo/builds/202409883>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3708 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95N-vdqSKBlpdx8GN56dOyvRdTPXMks5rdMfbgaJpZM4MBxLF>
.
|
|
⌛ Testing commit 73f870c with merge db7c5bc... |
|
💔 Test failed - status-travis |
|
@bors: retry
…On Thu, Feb 16, 2017 at 11:48 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/cargo/builds/202510040>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3708 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95MPw_8rn4-yfic4E1CvzsR53M15mks5rdTSWgaJpZM4MBxLF>
.
|
|
⌛ Testing commit 73f870c with merge 83135c8... |
|
💔 Test failed - status-travis |
|
@bors: retry
…On Fri, Feb 17, 2017 at 12:04 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/cargo/builds/202513378>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3708 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95OTtPKzoFfP64mAPrYoA7W0GoM0zks5rdThYgaJpZM4MBxLF>
.
|
|
⌛ Testing commit 73f870c with merge 1e3a7d2... |
|
💔 Test failed - status-travis |
|
@bors: retry
…On Fri, Feb 17, 2017 at 12:20 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/cargo/builds/202713405>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3708 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95CD8hOA0JfgCkyc9STua-XD8EMYiks5rdeTWgaJpZM4MBxLF>
.
|
|
⌛ Testing commit 73f870c with merge a8539c5... |
|
💔 Test failed - status-travis |
|
@bors: retry
…On Fri, Feb 17, 2017 at 2:56 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/cargo/builds/202757355>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3708 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95PG2YTth90sVCxpeIIj8HKEM_6kLks5rdglngaJpZM4MBxLF>
.
|
|
⌛ Testing commit 73f870c with merge 3bf6c41... |
|
💔 Test failed - status-travis |
|
@alexcrichton the last couple of mac failures appear to be legit. This test fails: 73f870c
|
On macs, mtime has a seconds granularity, so we need to sleep a bit
|
Ah, |
|
@bors: r+ |
|
📌 Commit 3d15df9 has been approved by |
Assert that we don't build test project twice. Discussed in #3691 (comment). I've modify the offending tests to be more explicit about recreating projects.
|
☀️ Test successful - status-appveyor, status-travis |
Discussed in #3691 (comment).
I've modify the offending tests to be more explicit about recreating projects.