Check the exit code of all processes started in the build/test tests #3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
By not checking the exit codes, a failure in the build::crate_env_vars() test was ignored.
sdroege
force-pushed
the
test-build-doc-test-check-status
branch
from
5dd9457 to
446486b
Compare
sdroege
changed the title
|
@bors: r+ Thanks! |
|
📌 Commit 446486b has been approved by |
|
⌛ Testing commit 446486b with merge 6f9b1eb... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network error
…On Tue, Jan 10, 2017 at 11:29 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/cargo/builds/190709120>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3524 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95Nd6-FxlXVwXTEZAb89cXo-p5ruEks5rQ9wlgaJpZM4LfVnS>
.
|
bors
added a commit
that referenced
this pull request
Jan 10, 2017
…xcrichton Check the exit code of all processes started in the build/test tests By not checking the exit codes, a failure in the build::crate_env_vars() test was ignored. As suggested by @alexcrichton in #3515 (comment)
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not checking the exit codes, a failure in the build::crate_env_vars()
test was ignored.
As suggested by @alexcrichton in #3515 (comment)