Parser clean #2858
Parser clean #2858
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| { | ||
| let dep_iter = ds[0].iter().map(|d| (d, None)) | ||
| .chain(ds[1].iter().map(|d| (d, Some(Kind::Development)))) | ||
| .chain(ds[2].iter().map(|d| (d, Some(Kind::Build)))) |
There was a problem hiding this comment.
This seems a little magical to me, could the previous behavior of passing this in explicitly be kept instead?
Ericson2314
force-pushed
the
parser-clean
branch
from
6a02b55 to
b4379aa
Compare
|
Both fixed! Issue for the former todos is #2869 |
Parser clean A few misc shortenings, mainly from my stdlib deps prototype. See the TODOs for some questions.
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
A few misc shortenings, mainly from my stdlib deps prototype. See the TODOs for some questions.