Skip to content

[beta 1.98] Backport new build-dir layout bug fixes#17207

Merged
weihanglo merged 9 commits into
rust-lang:rust-1.98.0from
ranger-ross:backport-search-path-fixes
Jul 12, 2026
Merged

[beta 1.98] Backport new build-dir layout bug fixes#17207
weihanglo merged 9 commits into
rust-lang:rust-1.98.0from
ranger-ross:backport-search-path-fixes

Conversation

@ranger-ross

@ranger-ross ranger-ross commented Jul 12, 2026

Copy link
Copy Markdown
Member

Backports:

Was only planning to backport #17191 but it builds on tests added in #17168 so was getting merge conflicts. Given they are both bug fixes and the new build-dir layout is still unstable, I figured it would be simpler to backport both fixes.

r? @weihanglo

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2026
@rustbot

rustbot commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.98.0. Please double check that you specified the right target!

@weihanglo

Copy link
Copy Markdown
Member

We will need to backport also #17179

Since it turns out we're actually getting close to Rust 1.99.0 :)
@weihanglo weihanglo changed the title [beta 1.97] Backport new build-dir layout bug fixes [beta 1.98] Backport new build-dir layout bug fixes Jul 12, 2026

@weihanglo weihanglo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll do the beta module update then :)

View changes since this review

@weihanglo
weihanglo enabled auto-merge July 12, 2026 14:57
@weihanglo
weihanglo merged commit 8640645 into rust-lang:rust-1.98.0 Jul 12, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 12, 2026
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Jul 12, 2026
[beta-1.98] Update cargo submodule

1 commits in f40cc7a13a8ebe3dd0a35b1e0e37a1e26c8bb0e5..864064524a7205e670579b6873d9b18897437eaf
2026-07-01 18:57:21 +0000 to 2026-07-12 08:11:54 -0700
- [beta 1.98] Backport new `build-dir` layout bug fixes (rust-lang/cargo#17207)
@rustbot rustbot added this to the 1.98.0 milestone Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-build-execution Area: anything dealing with executing the compiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants